Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to derivable account abstraction #16128

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 15, 2025

@igor-aptos igor-aptos force-pushed the igor/rename_to_derivable_aa branch from 731dd41 to 6b9e363 Compare March 16, 2025 04:59
@igor-aptos igor-aptos force-pushed the igor/rename_to_derivable_aa branch from 6b9e363 to da60415 Compare March 18, 2025 06:50
@igor-aptos igor-aptos force-pushed the igor/rename_to_derivable_aa branch from da60415 to 0bd9402 Compare March 18, 2025 19:01
@igor-aptos igor-aptos force-pushed the igor/rename_to_derivable_aa branch from 0bd9402 to 6f5872b Compare March 18, 2025 21:43
@igor-aptos igor-aptos enabled auto-merge (squash) March 18, 2025 21:44

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos removed the v1.28 label Mar 19, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/rename_to_derivable_aa branch from 6f5872b to 0f79bcb Compare March 20, 2025 02:22

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 0f79bcbf296df256e047a815855a7f382dc9d43d

two traffics test: inner traffic : committed: 12268.37 txn/s, submitted: 12273.74 txn/s, expired: 5.37 txn/s, latency: 3221.06 ms, (p50: 3000 ms, p70: 3300, p90: 4800 ms, p99: 9200 ms), latency samples: 4664680
two traffics test : committed: 99.99 txn/s, latency: 3332.97 ms, (p50: 2600 ms, p70: 4100, p90: 5200 ms, p99: 11900 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.363, avg: 0.859", "ConsensusProposalToOrdered: max: 0.316, avg: 0.307", "ConsensusOrderedToCommit: max: 0.474, avg: 0.427", "ConsensusProposalToCommit: max: 0.781, avg: 0.734"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.46s no progress at version 3128736 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.14s no progress at version 3076047 (avg 1.14s) [limit 16].
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d

Compatibility test results for 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d (PR)
1. Check liveness of validators at old version: 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc
compatibility::simple-validator-upgrade::liveness-check : committed: 3636.88 txn/s, submitted: 3637.15 txn/s, expired: 0.28 txn/s, latency: 3872.35 ms, (p50: 4200 ms, p70: 4500, p90: 4800 ms, p99: 5100 ms), latency samples: 290598
2. Upgrading first Validator to new version: 0f79bcbf296df256e047a815855a7f382dc9d43d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2670.06 txn/s, latency: 10908.63 ms, (p50: 11800 ms, p70: 13500, p90: 13900 ms, p99: 14000 ms), latency samples: 59920
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2614.82 txn/s, latency: 12767.84 ms, (p50: 14300 ms, p70: 14700, p90: 15100 ms, p99: 15200 ms), latency samples: 97940
3. Upgrading rest of first batch to new version: 0f79bcbf296df256e047a815855a7f382dc9d43d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2567.70 txn/s, latency: 11333.10 ms, (p50: 12600 ms, p70: 14100, p90: 14200 ms, p99: 14400 ms), latency samples: 57280
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2557.14 txn/s, latency: 13003.76 ms, (p50: 14400 ms, p70: 14900, p90: 15100 ms, p99: 15400 ms), latency samples: 96480
4. upgrading second batch to new version: 0f79bcbf296df256e047a815855a7f382dc9d43d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 4702.17 txn/s, latency: 6362.70 ms, (p50: 6800 ms, p70: 7300, p90: 8900 ms, p99: 9200 ms), latency samples: 98720
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4827.26 txn/s, latency: 6967.62 ms, (p50: 6900 ms, p70: 8100, p90: 9200 ms, p99: 9300 ms), latency samples: 169660
5. check swarm health
Compatibility test for 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d

Compatibility test results for 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d (PR)
Upgrade the nodes to version: 0f79bcbf296df256e047a815855a7f382dc9d43d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1808.68 txn/s, submitted: 1816.48 txn/s, failed submission: 7.80 txn/s, expired: 7.80 txn/s, latency: 1615.75 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 3400 ms), latency samples: 162360
Upgrade the remaining nodes to version: 0f79bcbf296df256e047a815855a7f382dc9d43d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1859.22 txn/s, submitted: 1865.84 txn/s, failed submission: 6.62 txn/s, expired: 6.62 txn/s, latency: 1549.52 ms, (p50: 1500 ms, p70: 1800, p90: 2100 ms, p99: 3300 ms), latency samples: 168560
5. check swarm health
Compatibility test for 43bffaa90de90abd3e9f4d3dfcac0b5855d661bc ==> 0f79bcbf296df256e047a815855a7f382dc9d43d passed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1673.37 txn/s, submitted: 1680.00 txn/s, failed submission: 6.62 txn/s, expired: 6.62 txn/s, latency: 1746.04 ms, (p50: 1500 ms, p70: 1800, p90: 2500 ms, p99: 4900 ms), latency samples: 151560
Test Ok

@igor-aptos igor-aptos merged commit b7147e7 into main Mar 20, 2025
43 of 46 checks passed
@igor-aptos igor-aptos deleted the igor/rename_to_derivable_aa branch March 20, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants