Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] opt proposal #16126

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[consensus] opt proposal #16126

wants to merge 6 commits into from

Conversation

danielxiangzl
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@danielxiangzl danielxiangzl added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Mar 14, 2025
Copy link

trunk-io bot commented Mar 14, 2025

⏱️ 3h 52m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 47m 🟩🟩
test-target-determinator 36m 🟩🟩🟩 (+4 more)
forge-e2e-test / forge 34m 🟥🟥🟥
forge-e2e-test / forge 26m 🟩🟩
check-dynamic-deps 25m 🟩🟩🟩🟩🟩 (+5 more)
rust-cargo-deny 13m 🟩🟩🟩🟩 (+3 more)
forge-compat-test / forge 12m 🟩
execution-performance / test-target-determinator 11m 🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+5 more)
general-lints 3m 🟩🟩🟩🟩 (+3 more)
fetch-last-released-docker-image-tag 3m 🟩🟩
file_change_determinator 2m 🟩🟩🟩🟩 (+4 more)
file_change_determinator 1m 🟩🟩🟩🟩 (+5 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@danielxiangzl danielxiangzl added CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR and removed CICD:run-forge-e2e-perf Run the e2e perf forge only labels Mar 18, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d6b8b0085e649a6d3ec408fe6a81f71582827882

two traffics test: inner traffic : committed: 11799.96 txn/s, latency: 3363.34 ms, (p50: 3200 ms, p70: 3500, p90: 4800 ms, p99: 5700 ms), latency samples: 4486600
two traffics test : committed: 99.99 txn/s, latency: 3184.26 ms, (p50: 2800 ms, p70: 3800, p90: 5200 ms, p99: 11700 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.388, avg: 0.674", "ConsensusProposalToOrdered: max: 0.334, avg: 0.324", "ConsensusOrderedToCommit: max: 0.446, avg: 0.338", "ConsensusProposalToCommit: max: 0.770, avg: 0.663"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.74s no progress at version 33367 (avg 0.13s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 2.22s no progress at version 2174093 (avg 2.22s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 82240c9c7137087c575bf5d670abfa0dddc3ae9f ==> d6b8b0085e649a6d3ec408fe6a81f71582827882

Compatibility test results for 82240c9c7137087c575bf5d670abfa0dddc3ae9f ==> d6b8b0085e649a6d3ec408fe6a81f71582827882 (PR)
1. Check liveness of validators at old version: 82240c9c7137087c575bf5d670abfa0dddc3ae9f
compatibility::simple-validator-upgrade::liveness-check : committed: 10908.35 txn/s, latency: 2837.53 ms, (p50: 2900 ms, p70: 3100, p90: 3700 ms, p99: 4100 ms), latency samples: 364520
2. Upgrading first Validator to new version: d6b8b0085e649a6d3ec408fe6a81f71582827882
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2762.18 txn/s, latency: 10395.75 ms, (p50: 10800 ms, p70: 12200, p90: 13100 ms, p99: 13100 ms), latency samples: 64420
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2745.81 txn/s, latency: 12058.70 ms, (p50: 12900 ms, p70: 14200, p90: 14500 ms, p99: 14600 ms), latency samples: 104420
3. Upgrading rest of first batch to new version: d6b8b0085e649a6d3ec408fe6a81f71582827882
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3032.99 txn/s, latency: 9641.92 ms, (p50: 10300 ms, p70: 11900, p90: 12600 ms, p99: 12600 ms), latency samples: 66620
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3052.30 txn/s, latency: 11050.52 ms, (p50: 12000 ms, p70: 12700, p90: 13000 ms, p99: 13000 ms), latency samples: 118360
4. upgrading second batch to new version: d6b8b0085e649a6d3ec408fe6a81f71582827882
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5228.20 txn/s, latency: 5880.47 ms, (p50: 6700 ms, p70: 7100, p90: 7400 ms, p99: 7500 ms), latency samples: 102020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5060.10 txn/s, latency: 6798.55 ms, (p50: 7400 ms, p70: 7400, p90: 7500 ms, p99: 7900 ms), latency samples: 177620
5. check swarm health
Compatibility test for 82240c9c7137087c575bf5d670abfa0dddc3ae9f ==> d6b8b0085e649a6d3ec408fe6a81f71582827882 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant