[move-vm][rac] Bytecode verification #16092
Open
+339
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
⏱️ 38m total CI duration on this PR
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vineethk
approved these changes
Mar 13, 2025
wrwg
force-pushed
the
graphite-base/16092
branch
from
7023bd5 to
0e8c4e6
Compare
wrwg
force-pushed
the
graphite-base/16092
branch
from
0e8c4e6 to
a0922c9
Compare
wrwg
force-pushed
the
graphite-base/16092
branch
from
a0922c9 to
1a0505c
Compare
16 tasks
wrwg
force-pushed
the
wrwg/rac-verify
branch
2 times, most recently
from
aa0025b to
94c132d
Compare
|
@wrwg prop test is still failing with unmatched txn execution status. |
This adds bound checking bytecode verification to access specifiers. Besides this, no further action the verifier is needed for RAC specifiers. Unit tests have been added for verification failures.
georgemitenkov
approved these changes
Mar 24, 2025
| check_bounds_impl(self.view.address_identifiers(), *addr_idx)? | ||
| }, | ||
| AddressSpecifier::Parameter(loc_idx, fun_opt) => { | ||
| let sign = self.view.signature_at(function.parameters); |
There was a problem hiding this comment.
Based on documentation:
/// The index of a parameter of the current function. If `modifier` is not given, the
/// parameter must have address type. Otherwise `modifier` must be a function which takes
/// a value (or reference) of the parameter type and delivers an address.
I am not familiar with this code, where do we check that the type at index in sign is address iff fun_opt.is_none()? Where do we check the function signature that it returns an address?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds bound checking bytecode verification to access specifiers. Besides this, no further action the verifier is needed for RAC specifiers.
How Has This Been Tested?
Unit tests have been added for verification failures.
Type of Change
Which Components or Systems Does This Change Impact?