Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aptos stdlib, aptos tokens, aptos token objects to move 2 #16056

Merged
merged 13 commits into from
Mar 26, 2025

Conversation

gregnazario
Copy link
Contributor

Description

This converts all of the code to Move 2. Some index behavior was skipped, but mostly changed.

How Has This Been Tested?

Tests passed locally, specifications were also run once, but may need to be tested in CI.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Mar 5, 2025

⏱️ 29m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 14m 🟩🟩🟩🟩🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
general-lints 3m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 58s 🟩🟩🟩🟩🟩
permission-check 15s 🟩🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@movekevin movekevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Did you write a CLI or script to do this? Could be good to commoditize that

@gregnazario gregnazario force-pushed the aptos-tokens-move-2 branch 3 times, most recently from 18173a3 to 661a086 Compare March 11, 2025 02:50
@gregnazario gregnazario force-pushed the aptos-tokens-move-2 branch 2 times, most recently from 0bf35ee to 7c6f9d1 Compare March 20, 2025 01:34
@gregnazario gregnazario enabled auto-merge (squash) March 20, 2025 01:34

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@gregnazario gregnazario force-pushed the aptos-tokens-move-2 branch from 2c0ca53 to 6f08550 Compare March 25, 2025 21:22

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f39eb5b200a950f2084be2b6323d4a36ce55b64b

two traffics test: inner traffic : committed: 12670.40 txn/s, latency: 3138.98 ms, (p50: 2700 ms, p70: 3100, p90: 4800 ms, p99: 5900 ms), latency samples: 4817540
two traffics test : committed: 99.97 txn/s, latency: 3151.02 ms, (p50: 2500 ms, p70: 4100, p90: 5000 ms, p99: 7300 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.055, avg: 0.466", "ConsensusProposalToOrdered: max: 0.302, avg: 0.299", "ConsensusOrderedToCommit: max: 0.617, avg: 0.437", "ConsensusProposalToCommit: max: 0.918, avg: 0.736"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.63s no progress at version 40779 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.01s no progress at version 2613918 (avg 1.01s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b

Compatibility test results for 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b (PR)
1. Check liveness of validators at old version: 74ec035bfe20765966d9e0fe389f4ed399f34b4e
compatibility::simple-validator-upgrade::liveness-check : committed: 9038.74 txn/s, latency: 3761.85 ms, (p50: 3000 ms, p70: 3200, p90: 7800 ms, p99: 8700 ms), latency samples: 297000
2. Upgrading first Validator to new version: f39eb5b200a950f2084be2b6323d4a36ce55b64b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2984.37 txn/s, latency: 9808.31 ms, (p50: 10200 ms, p70: 10600, p90: 11500 ms, p99: 11700 ms), latency samples: 72040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2905.30 txn/s, latency: 11490.44 ms, (p50: 12700 ms, p70: 13100, p90: 13500 ms, p99: 13500 ms), latency samples: 111120
3. Upgrading rest of first batch to new version: f39eb5b200a950f2084be2b6323d4a36ce55b64b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2938.48 txn/s, latency: 10897.82 ms, (p50: 10500 ms, p70: 13000, p90: 13200 ms, p99: 13300 ms), latency samples: 83500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2816.75 txn/s, latency: 11785.02 ms, (p50: 13300 ms, p70: 13800, p90: 14000 ms, p99: 14000 ms), latency samples: 105760
4. upgrading second batch to new version: f39eb5b200a950f2084be2b6323d4a36ce55b64b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 5352.93 txn/s, latency: 5731.94 ms, (p50: 6500 ms, p70: 6900, p90: 7200 ms, p99: 7400 ms), latency samples: 104480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5593.49 txn/s, latency: 6128.32 ms, (p50: 6800 ms, p70: 6800, p90: 7100 ms, p99: 7200 ms), latency samples: 190540
5. check swarm health
Compatibility test for 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b

Compatibility test results for 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b (PR)
Upgrade the nodes to version: f39eb5b200a950f2084be2b6323d4a36ce55b64b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1591.71 txn/s, submitted: 1598.96 txn/s, failed submission: 7.25 txn/s, expired: 7.25 txn/s, latency: 1922.69 ms, (p50: 1500 ms, p70: 2000, p90: 3500 ms, p99: 5500 ms), latency samples: 140482
Upgrade the remaining nodes to version: f39eb5b200a950f2084be2b6323d4a36ce55b64b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1669.35 txn/s, submitted: 1673.97 txn/s, failed submission: 4.62 txn/s, expired: 4.62 txn/s, latency: 1772.58 ms, (p50: 1500 ms, p70: 1800, p90: 3000 ms, p99: 4900 ms), latency samples: 151760
5. check swarm health
Compatibility test for 74ec035bfe20765966d9e0fe389f4ed399f34b4e ==> f39eb5b200a950f2084be2b6323d4a36ce55b64b passed
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1540.08 txn/s, submitted: 1545.89 txn/s, failed submission: 5.81 txn/s, expired: 5.81 txn/s, latency: 1926.26 ms, (p50: 1500 ms, p70: 1900, p90: 3500 ms, p99: 4400 ms), latency samples: 137801
Test Ok

@gregnazario gregnazario merged commit 986baa8 into aptos-labs:main Mar 26, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants