HDDS-12446. Add a Grafana dashboard for low level RocksDB operations. #7992
Conversation
Change-Id: I8a40918a8e8a4b9d63e2d8253859a84742d3a412
|
While importing, I had to delete the UID for the data source for the data to show up. Can you try importing to a different Grafana cluster (local dev setup works as well) to filter out the deployment specific json. |
There was a problem hiding this comment.
Thank you @jojochuang for the patch, please find a few minor comments
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "beegq3lpjhvcwf" |
There was a problem hiding this comment.
We could consider skipping the inclusion of the datasource uid to simplify the import process for users.
Ref: grafana/grafana#60769
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "beegq3lpjhvcwf" |
There was a problem hiding this comment.
Same as the previous comment, we could skip the datasource uid field for all other instances!
| "timepicker": {}, | ||
| "timezone": "browser", | ||
| "title": "OM RocksDB", | ||
| "uid": "feegs4uzd60aoe", |
There was a problem hiding this comment.
We could exclude the dashboard-level uid field as well!
| "options": { | ||
| "mode": "exclude", | ||
| "names": [ | ||
| "{__name__=\"rocksdb_om_db_db_seek_median\", hostname=\"ccycloud-1.weichiu.root.comops.site\", instance=\"ccycloud-1.weichiu.root.comops.site:9874\", job=\"ozone\"}" |
There was a problem hiding this comment.
We may utilize {{ hostname }} instead for all instances where we are hardcoding the hostnames (Ref: link).
Change-Id: Ibd9635d6fa67bbac5c19a144a3af3eb155b1a705
|
Hi Tanvi, thanks for tips. Please check again if this is okay. |
There was a problem hiding this comment.
Thanks for working on this @jojochuang , I have left a few comments below regarding excluding hosts for the timeseries graphs
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Ozone Manager RocksDB.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Ozone Manager RocksDB.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Ozone Manager RocksDB.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Ozone Manager RocksDB.json
Outdated
Show resolved
Hide resolved
Change-Id: I3359245c3982fa045bad387dd21b15fc94a346b7
|
Thanks @Tejaskriya for spotting that. Not sure if this is right but I manually removed the overrides in the json output. Re-imported it and looks fine to me. |
|
Merged. Thanks @Tejaskriya @tanvipenumudy @kerneltime for review! |
What changes were proposed in this pull request?
HDDS-12446. Add a Grafana dashboard for low level RocksDB operations.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12446
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Please see the screenshots:
