Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning: don't wait for indexer before refresh #8202

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Versioning: don't wait for indexer before refresh #8202

wants to merge 2 commits into from

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 28, 2025 •
edited
Loading

indexing and versioning status updates can run concurrently since they don't interact with each other.

git status refresh typically takes < 1s even in large projects, while indexing can take much longer.

expected results:

  • you should see the git file status update long before indexing finishes. for example while switching between branches on larger projects or right after NB startup
  • no noteworthy regressions for indexing totals or other tasks

old behavior can be restored with -J-Dversioning.delayscan=true

@mbien mbien added subversion [ci] enable versioning job git [ci] enable versioning job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) mercurial [ci] aka hg; enable versioning job labels Jan 28, 2025
@mbien mbien force-pushed the git-dont-wait-for-indexer branch from 830c9e3 to 23b04a0 Compare March 18, 2025 05:40
@mbien mbien marked this pull request as ready for review March 18, 2025 05:40
@mbien mbien marked this pull request as draft March 18, 2025 05:57
mbien added 2 commits March 18, 2025 12:47
@mbien
language level cleanup (records, lambdas and simplifications)p
c2041c0
@mbien
Versioning: don't wait for indexer before refresh
ce8ef50 
 - indexing and versioning status updates can run concurrently since
   they don't interact with each other.
 - git status refresh typically takes < 1s even in large projects.
   indexing can take much longer.

fix and performance:

 - refresh versioning annotations on project open otherwise they
   might be missing on re-open until the tree is expanded
 - lock-free CacheIndex#get(file)
@mbien mbien force-pushed the git-dont-wait-for-indexer branch from 23b04a0 to ce8ef50 Compare March 18, 2025 11:50
@mbien mbien marked this pull request as ready for review March 18, 2025 11:50
@mbien mbien modified the milestone: NB26 Mar 18, 2025
@mbien mbien marked this pull request as draft March 18, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) git [ci] enable versioning job mercurial [ci] aka hg; enable versioning job performance subversion [ci] enable versioning job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbien