Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAVA_HOME should be documented as discriminating #852

Open
ppalaga opened this issue May 22, 2023 · 3 comments
Open

JAVA_HOME should be documented as discriminating #852

ppalaga opened this issue May 22, 2023 · 3 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented May 22, 2023

I guess yes, at least for the sake of documenting it.
I see that in DaemonCompatibilitySpec, it has a special position among the other discriminating options. But still, it is de facto discriminating, so we should put the discriminating flag on it. WDYT @gnodet ?
@ppalaga ppalaga changed the title Shouldn't JAVA_HOME be discriminating? JAVA_HOME should be discriminating May 22, 2023
ppalaga added a commit to ppalaga/mvnd that referenced this issue May 22, 2023
@ppalaga
JAVA_HOME should be discriminating apache#852
6abc968
@ppalaga
Copy link
Contributor Author

ppalaga commented May 22, 2023

I have added a commit to #851 - so @gnodet please veto that one if needed.

@gnodet
Copy link
Contributor

gnodet commented May 22, 2023

I have added a commit to #851 - so @gnodet please veto that one if needed.

I think it should be documented as discriminated, but it is handled specifically in a bunch of cases (as shown by the failings ITs), I think it may better to add some javadoc that will end-up in the help, wdyt ?

@ppalaga
Copy link
Contributor Author

ppalaga commented May 22, 2023 •
edited
Loading

it may better to add some javadoc that will end-up in the help

Good idea. Let me do it.

@ppalaga ppalaga changed the title JAVA_HOME should be discriminating JAVA_HOME should be documented as discriminating May 22, 2023
ppalaga added a commit to ppalaga/mvnd that referenced this issue May 22, 2023
@ppalaga
JAVA_HOME should be documented as discriminating apache#852
5c44b0d
ppalaga added a commit that referenced this issue May 23, 2023
@ppalaga
JAVA_HOME should be documented as discriminating #852
7d9a39b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnodet @ppalaga