-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip block cache deallocation to make shutdown fast #2683
Conversation
@wanghenshui You can run |
040b73a
to
32314c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to add a go test case for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PrepareRestoreDB()
also call CloseDB
, should it prevent from unmanage memory?
yes. i 'll make a single function from |
Co-authored-by: Twice <[email protected]>
Co-authored-by: hulk <[email protected]>
73cb87f
to
0eb10e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General LGTM but maybe in the future we can have better method for this, I think this flag can be set only when cli/main.cc
. But this is also ok to me
|
when blockcache size is too big, skip dtor could save shutdown time
ref https://groups.google.com/g/rocksdb/c/xQ_o9jWoFqg