-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add rocksdb.wal_compression
to allow enable wal compression
#2607
feat(config): add rocksdb.wal_compression
to allow enable wal compression
#2607
Conversation
# the WAL is read. | ||
# | ||
# Default is no | ||
rocksdb.wal_compression no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be none
and zstd
instead of no
and yes
to leave some upgrading space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
By the way, may I ask that is this only for write-heavy workload(maybe with long and compress-able key-values)? |
i have a lot key-value (uncompressed size in [256B, 8kB]) with good compression rate (value is json, where sum length of json's keys is bigger then json's values). finally i have a lot of free cpu. this pull request can help me decrease write load on disk and i can pickup cheaper ec2 |
I see, this make sense |
issue: #2606
add
rocksdb.wal_compression
to allow enable wal compressiononly zstd supported, so field YesOrNo