fix: should remove the db lock from the context to prevent blocking user requests #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
git-hulk
changed the title
torwig
previously approved these changes
Oct 14, 2024
mapleFU
previously approved these changes
Oct 14, 2024
|
TSAN is caused by some commands that are allowed during restoring DB, which won't use the DB pointer in those commands like INFO/AUTH(commands with |
git-hulk
force-pushed
the
remove-db-lock-from-context
branch
from
abbba24 to
8d1bab3
Compare
PragmaTwice
reviewed
Oct 14, 2024
Comment on lines
+435
to
440
| const rocksdb::Snapshot *GetSnapshot() { | ||
| if (snapshot_ == nullptr) { | ||
| snapshot_ = storage->GetDB()->GetSnapshot(); // NOLINT | ||
| } | ||
| return snapshot_; | ||
| } |
There was a problem hiding this comment.
I think we should state here in comments that this method is NOT thread-safe.
PragmaTwice
approved these changes
Oct 14, 2024
|
cc @mapleFU PTAL |
|
mapleFU
approved these changes
Oct 14, 2024
nathanlo-hrt
pushed a commit
to nathanlo-hrt/kvrocks
that referenced
this pull request
Oct 17, 2024
git-hulk
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2596