feat(config): support retrieving configuration fields using glob patterns #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Oct 12, 2024
src/vendor/globmatch.cc
Outdated
|
|
||
| // NOLINTBEGIN | ||
| /* Glob-style pattern matching. */ | ||
| int stringmatchlen(const char *pattern, int patternLen, const char *string, int stringLen, int nocase) { |
There was a problem hiding this comment.
Seems we already have one called StringMatch in https://github.com/apache/kvrocks/blob/unstable/src/common/string_util.cc .
There was a problem hiding this comment.
ok, i'll use this one
PragmaTwice
reviewed
Oct 12, 2024
src/config/config.cc
Outdated
| @@ -867,7 +868,7 @@ Status Config::Load(const CLIOptions &opts) { | |||
| void Config::Get(const std::string &key, std::vector<std::string> *values) const { | |||
| values->clear(); | |||
| for (const auto &iter : fields_) { | |||
| if (key == "*" || util::ToLower(key) == iter.first) { | |||
| if (util::StringMatchLen(key.c_str(), key.size(), iter.first.c_str(), iter.first.size(), 1)) { | |||
There was a problem hiding this comment.
Suggested change
| if (util::StringMatchLen(key.c_str(), key.size(), iter.first.c_str(), iter.first.size(), 1)) { | |
| if (util::StringMatch(key, iter.first, 1)) { |
|
git-hulk
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be difficult to remember the full configuration field, so providing a keyword to retrieve the configuration value, as is done in Redis, can be more convenient.