feat(json): add support of JSON.RESP command #2390
Conversation
src/types/json.h
Outdated
| struct ArrayOrObjectPlaceHolder {}; | ||
| using VariantType = std::variant<std::string, int64_t, ArrayOrObjectPlaceHolder, bool>; | ||
| template <typename T> | ||
| struct JsonResp { | ||
| std::vector<std::unique_ptr<JsonResp<VariantType>>> children; | ||
| T value; | ||
| explicit JsonResp(T value) : value(std::move(value)) {} | ||
| }; |
There was a problem hiding this comment.
We can remove all of these types and just dump the RESP string directly.
src/types/json.h
Outdated
| if (path != "$") { | ||
| return redis::MultiLen(query_count) + json_resps; | ||
| } |
There was a problem hiding this comment.
seems not consistent with RedisJSON here.
json.resp a $ and json.resp a have different behavior.
There was a problem hiding this comment.
we can move redis::MultiLen(query_count) here to CommandJsonResp::Parse/Execute.
and here we can return vector<string>.
There was a problem hiding this comment.
Thank you for the reminder. It has not been modified yet. make the PR draft first
There was a problem hiding this comment.
It has been modified, but it is a bit unsupported. jsoncons does not support queries without $, Redis 7.0 supports it and will remove the outermost array
|
https://redis.io/docs/latest/commands/json.resp/
Local testing of multi-layer nested JSON results 6666 kvrocks and 6388 redis stack