-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ASKING command #2273
Support ASKING command #2273
Conversation
Yes, exactly. But we can fix this behavior after supporting the ASKING command. By the way, guess we should clear the ASKING flag after executing the next query? |
Yes, Fixing it will make kvorcks more like with redis in behavior. Let me do it. |
@git-hulk Hi, done it, please review |
I find that the kvrocks doesn't seem to return |
@jjz921024 Thank you! Generally looks good to me, you can fix the Go format to pass the CI. |
Yes, I had fix it |
|
Close #2168
Support ASKING command,but didn't do anythins. Because the kvrocks seems will serving the imported slot despite the lack of asking flag
kvrocks/src/cluster/cluster.cc
Lines 857 to 862 in ae5784d