Fix missing fields in HELLO command response #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we're missing the 'version', 'role', 'modules' in HELLO command which may cause the compability issue in some clients like Java lettuce: ``` Caused by: java.lang.IllegalArgumentException: Version must not be null at io.lettuce.core.internal.LettuceAssert.notNull(LettuceAssert.java:71) at io.lettuce.core.RedisHandshake$RedisVersion.<init>(RedisHandshake.java:333) at io.lettuce.core.RedisHandshake$RedisVersion.of(RedisHandshake.java:362) at io.lettuce.core.RedisHandshake.applyPostHandshake(RedisHandshake.java:249) at io.lettuce.core.RedisHandshake.lambda$initialize$0(RedisHandshake.java:99) ``` For the HELLO command response refer: https://redis.io/commands/hello/
|
This issue was reported by the user |
torwig
previously approved these changes
Mar 10, 2024
|
Thank you for the prompt fix What is the nightly docker img - i can try it out |
|
@asad-awadia Need to wait for this PR to be merged, and then you can have a try at |
asad-awadia
reviewed
Mar 11, 2024
torwig
approved these changes
Mar 11, 2024
jihuayu
approved these changes
Mar 11, 2024
|
Thanks for catching this! |
PragmaTwice
reviewed
Mar 11, 2024
Tried the nightly image and works as expected with resp3 default in lettuce :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're missing the 'version', 'role', 'modules' in the HELLO command which may cause the compatibility issue in some clients like Java lettuce:
For the HELLO command response refer: https://redis.io/commands/hello/