Fix incorrent bytes to calculate length of ziplist/listpack 32bit string #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it calculates the length of 32bit string from position 0 to 3, but the right position should be 0 to 4 in ziplist and listpack. So it will retrieve a wrong length and throw an error.
PragmaTwice
approved these changes
Feb 28, 2024
torwig
approved these changes
Feb 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it calculates the length of 32-bit string from position 0 to 3, but the right position should be 1 to 4 in ziplist/listpack. So it will retrieve a wrong length and throw an error.
also refer: https://github.com/redis/redis/blob/unstable/src/listpack.c#L101
This closes #2118