Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of EXPIRETIME and PEXPIRETIME #1965

Merged
merged 9 commits into from
Dec 26, 2023

Conversation

kay011
Copy link
Contributor

@kay011 kay011 commented Dec 24, 2023

This commit finish the #1948 and #1947.
It should be noted that since the timeout precision currently supported by kvrocks is seconds, the results obtained by executing PEXPIRETIME will be different from those obtained by redis. This is my first time trying to implement a kvrocks command, please give me your code review comments. Thanks!

@PragmaTwice
Copy link
Member

PragmaTwice commented Dec 24, 2023

Thanks for your effort!

It should be noted that since the timeout precision currently supported by kvrocks is seconds, the results obtained by executing PEXPIRETIME will be different from those obtained by redis.

If you build kvrocks with -DENABLE_NEW_ENCODING=ON, you can see that the precision of these expire time is in milliseconds.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@git-hulk
Copy link
Member

@kay011 Thanks for your contribution and quick response.

@git-hulk git-hulk requested a review from PragmaTwice December 26, 2023 02:50
@git-hulk git-hulk merged commit 7a08dfd into apache:unstable Dec 26, 2023
@kay011 kay011 deleted the feature_cmd_expiretime branch January 6, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants