support pinnable slice get #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisxu333
force-pushed
the
pinnable_slice_support
branch
from
e7794a3 to
021ac77
Compare
mapleFU
reviewed
Nov 15, 2023
git-hulk
reviewed
Nov 17, 2023
chrisxu333
force-pushed
the
pinnable_slice_support
branch
from
0541850 to
84fe581
Compare
PragmaTwice
reviewed
Nov 18, 2023
|
CI failed on macOS and ASAN build (use-after-free behaviors are found). |
mapleFU
reviewed
Nov 19, 2023
Okay I went through the code and I thought it might be related to pinnable slice copy into bf_data_list container. |
chrisxu333
force-pushed
the
pinnable_slice_support
branch
from
88618d3 to
dd5b5ae
Compare
mapleFU
reviewed
Nov 20, 2023
chrisxu333
force-pushed
the
pinnable_slice_support
branch
2 times, most recently
from
c80a370 to
899f79c
Compare
|
Hi @mapleFU , I saw all tests are passed for this pr. So do you mind helping merge this pr after I rebase it with the |
|
Generall LGTM. I'll take a carefully pass before merging tomorrow |
chrisxu333
force-pushed
the
pinnable_slice_support
branch
from
899f79c to
2553a25
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mapleFU
approved these changes
Nov 25, 2023
git-hulk
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1722
Support Get with rocksdb::PinnableSlice, so that relatively large objects like Bitmap and BloomFilter could avoid in-memory copy.