Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the JSON.OBJLEN command #1860

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Support for the JSON.OBJLEN command #1860

merged 3 commits into from
Dec 5, 2023

Conversation

isHuangXin
Copy link
Contributor

@isHuangXin isHuangXin commented Oct 29, 2023 •
edited by git-hulk
Loading

This closes #1821

This feature will support JSON.OBJLEN | Redis.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
26.5% 26.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@git-hulk
Copy link
Member

git-hulk commented Dec 4, 2023

@isHuangXin Are you still working on this PR?

@git-hulk git-hulk self-requested a review December 4, 2023 14:55
@git-hulk
Copy link
Member

git-hulk commented Dec 4, 2023 •
edited
Loading

@isHuangXin I have added the test case now.

@git-hulk git-hulk requested a review from PragmaTwice December 4, 2023 14:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.6% 2.6% Duplication

@git-hulk git-hulk merged commit b889b0e into apache:unstable Dec 5, 2023
@julic20s julic20s mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the JSON.OBJLEN command
2 participants
@isHuangXin @git-hulk