Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the support of LMPOP command #1737

Merged
merged 14 commits into from
Sep 6, 2023
Merged

Add the support of LMPOP command #1737

merged 14 commits into from
Sep 6, 2023

Conversation

HolyLow
Copy link
Contributor

@HolyLow HolyLow commented Sep 4, 2023

This PR adds support for LMPOP command.
Currently the test cases are not added yet, but will soon. This PR serves as an implementation preview.
Any suggestions are welcomed.

@HolyLow HolyLow mentioned this pull request Sep 4, 2023
Closed
2 tasks
@PragmaTwice PragmaTwice changed the title Add the support of LMPOP command (#1526) Add the support of LMPOP command Sep 4, 2023
@PragmaTwice PragmaTwice linked an issue Sep 4, 2023 that may be closed by this pull request
Add the support of the LMPOP command #1526
Closed
2 tasks
@PragmaTwice
Copy link
Member

Thanks for your contribution!

Please refer to https://kvrocks.apache.org/community/contributing/ to format, lint and test your code : )

git-hulk
git-hulk reviewed Sep 4, 2023
View reviewed changes
git-hulk
git-hulk reviewed Sep 5, 2023
View reviewed changes
git-hulk
git-hulk previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mapleFU
mapleFU reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM. The test is reach, thanks for the carefully testing!

torwig
torwig reviewed Sep 5, 2023
View reviewed changes
@git-hulk git-hulk requested review from git-hulk and torwig September 6, 2023 13:43
mapleFU
mapleFU approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

torwig
torwig approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PragmaTwice PragmaTwice merged commit c791511 into apache:unstable Sep 6, 2023
@PragmaTwice
Copy link
Member

Thanks for your contribution!

@git-hulk git-hulk mentioned this pull request Sep 6, 2023
Merged
@HolyLow HolyLow deleted the lmpop branch September 8, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@mapleFU mapleFU mapleFU approved these changes

@enjoy-binbin enjoy-binbin Awaiting requested review from enjoy-binbin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the support of the LMPOP command
6 participants
@HolyLow @PragmaTwice @git-hulk @torwig @enjoy-binbin @mapleFU