Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the no-script flag in the LASTSAVE command #1708

Merged

Conversation

enjoy-binbin
Copy link
Member

Redis allow run it in the script:

127.0.0.1:6379> eval "return redis.call('lastsave')" 0
(integer) 1693277322

Look like a copy-paste bug.

Redis allow run it in the script:
```
127.0.0.1:6379> eval "return redis.call('lastsave')" 0
(integer) 1693277322
```

Look like a copy-paste bug.
@enjoy-binbin
Copy link
Member Author

another question, now run the no-script flag command will response this error:

127.0.0.1:6666> eval "return redis.call('lastsave')" 0
(error) ERR running script (call to f_d096f7c74e67ca72b33cecd3eb313f2d7732c9e6): This Redis command is not allowed from scripts

the error message mention This Redis command, maybe in the future we need to change this. since we may add some kvrocks-only commands?

@enjoy-binbin enjoy-binbin merged commit 592b24f into apache:unstable Aug 29, 2023
@enjoy-binbin enjoy-binbin deleted the remove_lastsave_no-script_flag branch August 29, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants