Fix INFO used_memory_rss_human field name #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name should be used_memory_rss_human according to the context and Redis documentation.
|
Not sure if anyone would rely on and use used_memory_human, i am leaning towards no... Note our doc also describes it as used_memory_rss_human in https://kvrocks.apache.org/docs/info-sections |
mapleFU
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Maybe jemalloc stats.resident or other can be used for used_memory and used_memory_human ? cc @PragmaTwice
git-hulk
approved these changes
Jul 18, 2023
It should be fine since used_memory_rss_human is only for human reading. |
PragmaTwice
approved these changes
Jul 18, 2023
|
Thanks. Merging... |
git-hulk
pushed a commit
to git-hulk/kvrocks
that referenced
this pull request
Jul 30, 2023
The name should be used_memory_rss_human according to the context and Redis documentation.
Merged
git-hulk
pushed a commit
that referenced
this pull request
Aug 1, 2023
The name should be used_memory_rss_human according to the context and Redis documentation.
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 1, 2023
The name should be used_memory_rss_human according to the context and Redis documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name should be used_memory_rss_human according to
the context and Redis documentation.