Avoid Write calls when SIADD added_cnt is 0 #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may improve performance by 40% in certain case. Simple benchmarks: ``` src/redis-benchmark -p 6666 -P 100 -n 100000 siadd key 1 2 3 ``` Before is 95057.03 requests per second. After is 135135.14 requests per second.
git-hulk
approved these changes
Jul 11, 2023
xiaobiaozhao
approved these changes
Jul 11, 2023
|
Why such a big performance boost? I don't get that from the logic of the code |
PragmaTwice
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may improve performance by 40% in certain case.
Simple benchmarks:
Before is 95057.03 requests per second.
After is 135135.14 requests per second.