Fix ZUNION hang in syntax error #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug introduce in apache#1502, without this return, when syntax error happen, the code will stuck in the while loop and result a hang.
|
this could be a security issue if there is a release that includes this command |
Yes, 2.5.0 is voting now, but I'm not sure if we should cancel the vote. This bug would cause the server to be trapped in the dead loop. cc @tisonkun @torwig @torwig @ShooterIT @ColinChamber |
PragmaTwice
approved these changes
Jul 6, 2023
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was introduced in #1502, without this return, when syntax
error happen, the code will stuck in the while loop and
result a hang.