-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Disable -static-libgcc
on MacOS building
#1555
Build: Disable -static-libgcc
on MacOS building
#1555
Conversation
LGTM, but I'm wondering why this error didn't happen on my side. |
@git-hulk did you get a warning like:
I'm not sure would it warns that |
I cannot see this warning even building from scratch. |
I guess there is something wrong with clang-13 on MacOS 12.2.1 . But I didn't research about it |
@mapleFU I know the reason now. Coz I'm using AppleClang Not Clang :D. |
Oh, so that :
will not step into. So no flags would be added here. Sounds reasonable |
Yes, that's right. |
I've update the description. |
Thanks all, merging... |
On MacOS clang-13, it doesn't support
-static-libgcc
. So the code below might get:This patch tries to fix that. This will make LLVM Clang failed, but AppleClang will not meet the problem.