Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove startupProbe in kubernetes-overlord-extensions #17784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove startupProbe in kubernetes-overlord-extensions #17784

wants to merge 2 commits into from

Conversation

applike-ss
Copy link

Partially Fixes #17783.

Description

The readiness and liveness probes are removed, however the startup probe remains - which makes peon tasks never get healthy and kills them after not coming up long enough.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

Removed Startup probe in kubernetes-overlord-extentions, so that peon tasks can start up properly without being killed by kubernetes.

Key changed/added classes in this PR
  • remove startup probe on peon tasks, if it exists

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

georgew5656
georgew5656 reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@georgew5656 georgew5656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if you have time could you add a unit test checking this behavior?

@applike-ss
Copy link
Author

I have added a unit test, but i can't execute it on my end because IntelliJ IDEA can't resolve org.apache.druid.math.expr.antlr.ExprBaseListener and org.apache.druid.math.expr.antlr.ExprParser.

Maybe you can try it?

@georgew5656
Copy link
Contributor

I have added a unit test, but i can't execute it on my end because IntelliJ IDEA can't resolve org.apache.druid.math.expr.antlr.ExprBaseListener and org.apache.druid.math.expr.antlr.ExprParser.

Maybe you can try it?

you should be able to run the tests and style check locally from the kubernetes-overlord-extension directory

@applike-ss
Copy link
Author

I have added a unit test, but i can't execute it on my end because IntelliJ IDEA can't resolve org.apache.druid.math.expr.antlr.ExprBaseListener and org.apache.druid.math.expr.antlr.ExprParser.
Maybe you can try it?

you should be able to run the tests and style check locally from the kubernetes-overlord-extension directory

I am aware that i should be able to run it and IntelliJ IDEA also has a run button, so that i can run specific tests.

However I assume that my local setup is not quite correct, so that it doesn't work.

I haven't developed Java in a century and even before that not on a professional level.

Feel free to fix what's not working or tell me where I can look for potential fixes for my local env.
Here's the errors I'm getting:

druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:29:40
java: package org.apache.druid.math.expr.antlr does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:30:40
java: package org.apache.druid.math.expr.antlr does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:47:39
java: cannot find symbol
  symbol: class ExprBaseListener
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:72:41
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:88:47
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:105:40
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:115:40
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:145:38
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:154:46
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:184:40
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:190:36
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:196:43
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:266:46
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:306:39
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:320:42
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:342:44
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:349:37
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:360:36
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:375:42
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:386:34
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:392:41
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:410:43
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:448:39
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:464:47
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:482:41
java: package ExprParser does not exist
druid/processing/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java:498:49
java: package ExprParser does not exist

@applike-ss
Copy link
Author

As you can see even the CI is failing due to some issues with twitter right now, so I guess this one will be delayed until they are stable again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgew5656 georgew5656 georgew5656 approved these changes

Assignees
No one assigned
Labels
Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MM-less with overlordSingleContainer type adds wrong startup probe for peon task
2 participants
@applike-ss @georgew5656