-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](s3client) Set ClientConfiguration.requestTimeoutMs default value from 3000ms to 30000ms #49315
Conversation
… 3000ms to 30000ms * ClientConfiguration.requestTimeoutMs default is 3000ms in `aws-sdk-cpp`, this should be more than adequate for most services. However, we meet problem when cloud provider's storage service or network not stable * refer to https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32902 ms
|
TPC-DS: Total hot run time: 185506 ms
|
ClickBench: Total hot run time: 31.5 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…e from 3000ms to 30000ms (#49315) * ClientConfiguration.requestTimeoutMs default is 3000ms in `aws-sdk-cpp`, this should be more than adequate for most services. However, we meet problem when cloud provider's storage service or network not stable * refer to https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h
ClientConfiguration.requestTimeoutMs default is 3000ms in
aws-sdk-cpp
, this should be more than adequate for most services. However, we meet problem when cloud provider's storage service or network not stablerefer to https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)