[fix](core) fix subreplace when inputting a large number of empty strings #49241

Mryange · 2025-03-19T04:58:39Z

What problem does this PR solve?

    #0 0x55f5cd170097 in doris::validate_ascii_fast(char const*, unsigned long) /mnt/disk12/yanxuecheng/tmp-doris/be/src/util/simd/vstring_function.h:60:37
    #1 0x55f5cd16e3c0 in doris::simd::VStringFunctions::is_ascii(doris::StringRef const&) /mnt/disk12/yanxuecheng/tmp-doris/be/src/util/simd/vstring_function.h:212:16
    #2 0x55f5cd16dcd3 in auto doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)::operator()<std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(auto, auto, auto, auto) const /mnt/disk12/yanxuecheng/tmp-doris/be/src/vec/functions/function_string.h:3600:25
    #3 0x55f5cd16d926 in auto std::__invoke_impl<void, doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(std::__invoke_other, auto&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61:14
    #4 0x55f5cd16d8b6 in std::__invoke_result<auto, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>::type std::__invoke<doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(auto&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:96:14
    #5 0x55f5cd16cfed in std::__detail::__variant::__gen_vtable_impl<std::__detail::__variant::_Multi_array<std::__detail::__variant::__deduce_visit_result<void> (*)(doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&)>, std::integer_sequence<unsigned long, 0ul, 0ul, 0ul, 0ul>>::__visit_invoke(doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1032:11
    #6 0x55f5cd16ce46 in decltype(auto) std::__do_visit<std::__detail::__variant::__deduce_visit_result<void>, doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>(auto&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1758:15
    #7 0x55f5cd16c7ca in std::invoke_result<auto, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>>::type std::visit<doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>(auto&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1859:9
    #8 0x55f5cd16bd75 in doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) /mnt/disk12/yanxuecheng/tmp-doris/be/src/vec/functions/function_string.h:3594:9

Related PR:(#40929)

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-03-19T04:58:45Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Mryange · 2025-03-19T04:59:40Z

run buildall

doris-robot · 2025-03-19T05:25:57Z

TPC-H: Total hot run time: 32779 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c5d7c39924f9c69143845bd5cf236017f4931e5, data reload: false

------ Round 1 ----------------------------------
q1	24517	5317	5088	5088
q2	2059	325	170	170
q3	10373	1249	705	705
q4	10234	1012	553	553
q5	7543	2816	2364	2364
q6	200	167	136	136
q7	948	743	608	608
q8	9320	1299	1178	1178
q9	4959	4763	4930	4763
q10	6851	2308	1922	1922
q11	468	275	263	263
q12	345	363	226	226
q13	17774	3709	3099	3099
q14	221	228	207	207
q15	544	475	475	475
q16	620	604	561	561
q17	556	891	360	360
q18	6921	6534	6378	6378
q19	1097	958	564	564
q20	333	339	199	199
q21	2973	2206	1965	1965
q22	1053	995	1001	995
Total cold run time: 109909 ms
Total hot run time: 32779 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5215	5161	5174	5161
q2	233	328	226	226
q3	2160	2638	2282	2282
q4	1408	1804	1445	1445
q5	4242	4165	4472	4165
q6	233	169	129	129
q7	2080	1907	1771	1771
q8	2660	2623	2570	2570
q9	7088	7219	7142	7142
q10	2997	3193	2759	2759
q11	571	507	479	479
q12	683	741	597	597
q13	3583	3944	3275	3275
q14	287	301	291	291
q15	533	480	478	478
q16	663	673	639	639
q17	1131	1619	1336	1336
q18	7942	7496	7315	7315
q19	853	818	1030	818
q20	1935	2022	1859	1859
q21	5470	5049	4712	4712
q22	1090	1019	1028	1019
Total cold run time: 53057 ms
Total hot run time: 50468 ms

doris-robot · 2025-03-19T05:37:25Z

TPC-DS: Total hot run time: 185736 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c5d7c39924f9c69143845bd5cf236017f4931e5, data reload: false

query1	1023	476	468	468
query2	6542	1982	1905	1905
query3	6794	215	215	215
query4	26235	23903	23279	23279
query5	5144	678	499	499
query6	339	213	193	193
query7	4613	501	314	314
query8	307	266	239	239
query9	8652	2625	2668	2625
query10	492	319	256	256
query11	15573	15189	14967	14967
query12	167	108	103	103
query13	1640	528	410	410
query14	9691	6216	6265	6216
query15	203	189	176	176
query16	7406	610	480	480
query17	1141	717	559	559
query18	1958	423	322	322
query19	187	183	151	151
query20	121	116	112	112
query21	210	121	111	111
query22	4173	4102	4153	4102
query23	34002	32940	32867	32867
query24	8229	2417	2442	2417
query25	531	454	382	382
query26	1239	274	192	192
query27	2600	496	325	325
query28	4386	2443	2426	2426
query29	750	552	436	436
query30	276	211	183	183
query31	930	873	719	719
query32	71	66	62	62
query33	579	381	314	314
query34	783	826	508	508
query35	797	830	744	744
query36	974	991	900	900
query37	119	102	75	75
query38	4264	4094	4039	4039
query39	1453	1394	1385	1385
query40	213	123	114	114
query41	56	53	53	53
query42	117	105	104	104
query43	512	526	489	489
query44	1318	803	793	793
query45	183	171	167	167
query46	838	1045	630	630
query47	1750	1800	1719	1719
query48	391	431	306	306
query49	804	543	450	450
query50	687	746	427	427
query51	4251	4243	4140	4140
query52	107	106	98	98
query53	237	258	188	188
query54	510	490	408	408
query55	84	83	81	81
query56	280	285	264	264
query57	1091	1118	1043	1043
query58	269	238	243	238
query59	2703	2674	2591	2591
query60	306	291	257	257
query61	141	138	119	119
query62	802	744	697	697
query63	234	192	192	192
query64	4288	987	661	661
query65	4420	4375	4375	4375
query66	1154	410	305	305
query67	15815	15376	15366	15366
query68	6043	896	518	518
query69	478	306	265	265
query70	1202	1135	1128	1128
query71	393	292	256	256
query72	5486	3578	3716	3578
query73	753	738	353	353
query74	9075	9109	8857	8857
query75	3202	3180	2724	2724
query76	3230	1198	832	832
query77	468	381	297	297
query78	9878	10221	9347	9347
query79	1651	791	585	585
query80	663	526	459	459
query81	491	269	223	223
query82	199	129	102	102
query83	176	168	157	157
query84	242	95	76	76
query85	753	359	308	308
query86	375	319	277	277
query87	4421	4448	4303	4303
query88	2878	2257	2275	2257
query89	390	327	287	287
query90	1930	234	213	213
query91	185	136	110	110
query92	70	60	63	60
query93	1337	1077	598	598
query94	670	410	314	314
query95	364	271	263	263
query96	486	555	281	281
query97	3256	3368	3301	3301
query98	230	218	205	205
query99	1335	1408	1251	1251
Total cold run time: 270465 ms
Total hot run time: 185736 ms

doris-robot · 2025-03-19T05:42:45Z

ClickBench: Total hot run time: 30.74 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c5d7c39924f9c69143845bd5cf236017f4931e5, data reload: false

query1	0.04	0.03	0.03
query2	0.11	0.11	0.10
query3	0.26	0.19	0.19
query4	1.59	0.20	0.10
query5	0.56	0.54	0.55
query6	1.20	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.55	0.53
query10	0.63	0.60	0.58
query11	0.16	0.10	0.10
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	2.65	2.82	2.68
query15	0.94	0.88	0.86
query16	0.39	0.39	0.38
query17	1.06	1.03	0.99
query18	0.22	0.20	0.20
query19	2.06	1.89	1.80
query20	0.01	0.02	0.02
query21	15.35	0.92	0.53
query22	0.75	1.31	0.72
query23	14.73	1.38	0.66
query24	7.39	1.37	0.53
query25	0.51	0.32	0.14
query26	0.62	0.15	0.14
query27	0.05	0.05	0.04
query28	8.96	0.86	0.44
query29	12.53	3.99	3.32
query30	0.25	0.09	0.06
query31	2.83	0.59	0.37
query32	3.23	0.54	0.46
query33	2.98	3.05	3.02
query34	15.80	5.09	4.47
query35	4.54	4.59	4.46
query36	0.66	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.95 s
Total hot run time: 30.74 s

doris-robot · 2025-03-19T07:11:12Z

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	48.79% (13068/26784)
Line Coverage	38.38% (112732/293706)
Region Coverage	37.17% (57288/154137)
Branch Coverage	32.28% (28807/89238)

yiguolei

LGTM

github-actions · 2025-03-19T08:32:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-19T08:32:52Z

PR approved by anyone and no changes requested.

Mryange · 2025-03-19T08:35:46Z

run buildall

github-actions · 2025-03-19T08:36:18Z

PR approved by at least one committer and no changes requested.

doris-robot · 2025-03-19T08:57:16Z

TPC-H: Total hot run time: 32288 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0941e8d44f803cd12e5ac446085d58d6f0bc98a7, data reload: false

------ Round 1 ----------------------------------
q1	24189	5038	5004	5004
q2	2044	311	174	174
q3	10393	1237	721	721
q4	10227	1000	546	546
q5	7539	2354	2384	2354
q6	195	172	140	140
q7	918	740	629	629
q8	9314	1301	1088	1088
q9	4863	4669	4541	4541
q10	6831	2298	1909	1909
q11	479	284	262	262
q12	341	359	214	214
q13	17772	3732	3116	3116
q14	225	233	206	206
q15	514	479	480	479
q16	621	642	608	608
q17	569	876	369	369
q18	6841	6444	6303	6303
q19	1212	936	538	538
q20	329	354	204	204
q21	2822	2213	1902	1902
q22	1022	995	981	981
Total cold run time: 109260 ms
Total hot run time: 32288 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5128	5115	5093	5093
q2	235	320	223	223
q3	2154	2658	2301	2301
q4	1427	1831	1373	1373
q5	4235	4098	4419	4098
q6	216	170	125	125
q7	2017	1923	1802	1802
q8	2614	2536	2461	2461
q9	7175	7240	7159	7159
q10	3007	3215	2755	2755
q11	563	510	494	494
q12	694	739	624	624
q13	3520	3922	3332	3332
q14	278	290	281	281
q15	538	474	467	467
q16	647	696	654	654
q17	1127	1585	1369	1369
q18	7664	7586	7523	7523
q19	786	811	812	811
q20	1982	2032	1876	1876
q21	5463	4825	4667	4667
q22	1047	1005	968	968
Total cold run time: 52517 ms
Total hot run time: 50456 ms

doris-robot · 2025-03-19T09:08:50Z

TPC-DS: Total hot run time: 185386 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0941e8d44f803cd12e5ac446085d58d6f0bc98a7, data reload: false

query1	1006	484	465	465
query2	6528	1943	1933	1933
query3	6794	229	214	214
query4	26636	23633	23113	23113
query5	4328	671	491	491
query6	305	207	186	186
query7	4607	504	310	310
query8	300	248	235	235
query9	8616	2615	2623	2615
query10	460	311	254	254
query11	15948	15149	14867	14867
query12	171	110	107	107
query13	1652	516	395	395
query14	10139	6240	6284	6240
query15	204	186	171	171
query16	7656	623	465	465
query17	1192	710	563	563
query18	1999	406	314	314
query19	190	193	161	161
query20	124	116	116	116
query21	208	122	105	105
query22	4386	4267	4224	4224
query23	33846	33037	33032	33032
query24	8220	2398	2369	2369
query25	523	447	416	416
query26	1239	275	157	157
query27	2669	500	326	326
query28	4292	2422	2406	2406
query29	720	559	425	425
query30	284	218	195	195
query31	967	856	758	758
query32	73	61	65	61
query33	558	377	304	304
query34	771	853	506	506
query35	799	792	739	739
query36	935	1017	930	930
query37	115	105	75	75
query38	4211	4263	4078	4078
query39	1447	1405	1425	1405
query40	208	116	105	105
query41	54	50	51	50
query42	118	106	100	100
query43	490	486	483	483
query44	1274	778	777	777
query45	179	178	163	163
query46	833	1023	630	630
query47	1746	1797	1713	1713
query48	369	414	308	308
query49	796	506	431	431
query50	689	721	406	406
query51	4177	4190	4083	4083
query52	111	101	94	94
query53	231	253	189	189
query54	483	495	419	419
query55	86	79	93	79
query56	260	273	242	242
query57	1114	1151	1072	1072
query58	244	235	237	235
query59	2697	2674	2682	2674
query60	279	307	253	253
query61	127	127	127	127
query62	803	733	655	655
query63	217	191	186	186
query64	4288	1055	661	661
query65	4466	4352	4373	4352
query66	1043	410	300	300
query67	15740	15707	15424	15424
query68	8322	863	501	501
query69	465	303	271	271
query70	1201	1115	1085	1085
query71	478	287	313	287
query72	5346	3499	3699	3499
query73	794	720	350	350
query74	9124	8925	8823	8823
query75	3849	3183	2724	2724
query76	3706	1184	766	766
query77	813	374	287	287
query78	10173	10176	9194	9194
query79	2236	826	577	577
query80	652	518	460	460
query81	479	254	221	221
query82	486	127	99	99
query83	206	173	158	158
query84	280	100	77	77
query85	777	349	297	297
query86	335	303	290	290
query87	4389	4420	4353	4353
query88	3481	2275	2300	2275
query89	392	317	278	278
query90	1926	218	215	215
query91	135	138	115	115
query92	72	61	60	60
query93	1389	1042	585	585
query94	677	424	307	307
query95	346	269	263	263
query96	482	580	276	276
query97	3329	3386	3262	3262
query98	229	212	211	211
query99	1456	1361	1283	1283
Total cold run time: 276265 ms
Total hot run time: 185386 ms

doris-robot · 2025-03-19T09:14:08Z

ClickBench: Total hot run time: 31.3 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0941e8d44f803cd12e5ac446085d58d6f0bc98a7, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.10	0.11
query3	0.24	0.19	0.19
query4	1.61	0.19	0.19
query5	0.60	0.58	0.60
query6	1.19	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.52	0.54
query10	0.58	0.58	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.61	0.60
query14	2.80	2.68	2.80
query15	0.92	0.85	0.83
query16	0.40	0.39	0.38
query17	1.02	1.00	1.01
query18	0.21	0.19	0.20
query19	1.95	1.94	1.83
query20	0.01	0.01	0.01
query21	15.35	0.90	0.54
query22	0.75	1.25	0.66
query23	14.88	1.38	0.65
query24	6.93	1.87	0.99
query25	0.48	0.29	0.12
query26	0.59	0.16	0.13
query27	0.05	0.04	0.04
query28	9.60	0.80	0.42
query29	12.55	3.99	3.32
query30	0.25	0.10	0.06
query31	2.84	0.61	0.39
query32	3.25	0.53	0.46
query33	2.95	3.04	3.13
query34	15.84	5.13	4.52
query35	4.53	4.51	4.47
query36	0.67	0.50	0.48
query37	0.09	0.07	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.25 s
Total hot run time: 31.3 s

doris-robot · 2025-03-19T10:56:52Z

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	48.82% (13075/26784)
Line Coverage	38.40% (112782/293710)
Region Coverage	37.19% (57323/154140)
Branch Coverage	32.30% (28824/89240)

dataroaring

LGTM

…ings (#49241) ### What problem does this PR solve? ``` #0 0x55f5cd170097 in doris::validate_ascii_fast(char const*, unsigned long) /mnt/disk12/yanxuecheng/tmp-doris/be/src/util/simd/vstring_function.h:60:37 #1 0x55f5cd16e3c0 in doris::simd::VStringFunctions::is_ascii(doris::StringRef const&) /mnt/disk12/yanxuecheng/tmp-doris/be/src/util/simd/vstring_function.h:212:16 #2 0x55f5cd16dcd3 in auto doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)::operator()<std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(auto, auto, auto, auto) const /mnt/disk12/yanxuecheng/tmp-doris/be/src/vec/functions/function_string.h:3600:25 #3 0x55f5cd16d926 in auto std::__invoke_impl<void, doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(std::__invoke_other, auto&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61:14 #4 0x55f5cd16d8b6 in std::__invoke_result<auto, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>::type std::__invoke<doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>, std::integral_constant<bool, false>>(auto&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&, std::integral_constant<bool, false>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:96:14 #5 0x55f5cd16cfed in std::__detail::__variant::__gen_vtable_impl<std::__detail::__variant::_Multi_array<std::__detail::__variant::__deduce_visit_result<void> (*)(doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&)>, std::integer_sequence<unsigned long, 0ul, 0ul, 0ul, 0ul>>::__visit_invoke(doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto)&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1032:11 #6 0x55f5cd16ce46 in decltype(auto) std::__do_visit<std::__detail::__variant::__deduce_visit_result<void>, doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>(auto&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1758:15 #7 0x55f5cd16c7ca in std::invoke_result<auto, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>, std::__conditional<is_lvalue_reference_v<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>>::type<std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&, std::variant_alternative<0ul, std::remove_reference<decltype(__variant::__as(std::declval<std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>()))>::type>::type&&>>::type std::visit<doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long)::'lambda'(auto, auto, auto, auto), std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>>(auto&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&, std::variant<std::integral_constant<bool, false>, std::integral_constant<bool, true>>&&) /mnt/disk6/common/ldb_toolchain_robin/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/variant:1859:9 #8 0x55f5cd16bd75 in doris::vectorized::SubReplaceImpl::replace_execute(doris::vectorized::Block&, std::vector<unsigned int, std::allocator<unsigned int>> const&, unsigned int, unsigned long) /mnt/disk12/yanxuecheng/tmp-doris/be/src/vec/functions/function_string.h:3594:9 ``` Related PR:(#40929)

…of empty strings #49241 (#49303) Cherry-picked from #49241 Co-authored-by: Mryange <[email protected]>

fix

7c5d7c3

yiguolei previously approved these changes Mar 19, 2025

View reviewed changes

yiguolei added p0_c dev/2.1.x dev/3.0.x labels Mar 19, 2025

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2025

github-actions bot added the reviewed label Mar 19, 2025

License

0941e8d

Mryange dismissed yiguolei’s stale review via 0941e8d March 19, 2025 08:33

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 19, 2025

yiguolei approved these changes Mar 19, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2025

dataroaring approved these changes Mar 20, 2025

View reviewed changes

yiguolei merged commit 7af13a4 into apache:master Mar 20, 2025
24 of 27 checks passed

github-actions bot mentioned this pull request Mar 20, 2025

branch-3.0: [fix](core) fix subreplace when inputting a large number of empty strings #49241 #49302

Open

github-actions bot mentioned this pull request Mar 20, 2025

branch-2.1: [fix](core) fix subreplace when inputting a large number of empty strings #49241 #49303

Merged

yiguolei pushed a commit that referenced this pull request Mar 20, 2025

branch-2.1: [fix](core) fix subreplace when inputting a large number …

ce49f37

…of empty strings #49241 (#49303) Cherry-picked from #49241 Co-authored-by: Mryange <[email protected]>

yiguolei added dev/2.1.9-merged and removed dev/2.1.x labels Mar 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](core) fix subreplace when inputting a large number of empty strings #49241

[fix](core) fix subreplace when inputting a large number of empty strings #49241

Mryange commented Mar 19, 2025 •

edited

Loading

Thearas commented Mar 19, 2025

Mryange commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

yiguolei left a comment

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

Mryange commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

dataroaring left a comment

[fix](core) fix subreplace when inputting a large number of empty strings #49241

[fix](core) fix subreplace when inputting a large number of empty strings #49241

Conversation

Mryange commented Mar 19, 2025 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Thearas commented Mar 19, 2025

Mryange commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

BE UT Coverage Report

yiguolei left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

Mryange commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

doris-robot commented Mar 19, 2025

BE UT Coverage Report

dataroaring left a comment

Choose a reason for hiding this comment

Mryange commented Mar 19, 2025 •

edited

Loading