Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] (nereids) implement transactionBegin/Commit/RollbackCommand in nereids #48993

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yx-keith
Copy link
Contributor

@yx-keith yx-keith commented Mar 12, 2025

What problem does this PR solve?

Issue Number: close #42535, #42537, #42538

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yx-keith
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32427 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7f41ddc2aa3a3c5e69fef57c9ad78c99e8fb9301, data reload: false

------ Round 1 ----------------------------------
q1	17603	5203	5089	5089
q2	2045	284	162	162
q3	10567	1339	722	722
q4	10291	1016	535	535
q5	8280	2404	2379	2379
q6	193	165	132	132
q7	924	740	610	610
q8	9304	1231	1122	1122
q9	5036	4767	4755	4755
q10	6812	2314	1889	1889
q11	464	272	254	254
q12	353	357	212	212
q13	17764	3675	3125	3125
q14	232	238	213	213
q15	526	483	481	481
q16	624	626	565	565
q17	576	858	352	352
q18	6932	6624	6206	6206
q19	1365	961	542	542
q20	312	344	191	191
q21	2744	2153	1922	1922
q22	1049	1048	969	969
Total cold run time: 103996 ms
Total hot run time: 32427 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5148	5149	5125	5125
q2	235	327	234	234
q3	2164	2662	2292	2292
q4	1425	1844	1403	1403
q5	4256	4130	4201	4130
q6	202	173	124	124
q7	1878	1979	1746	1746
q8	2656	2652	2527	2527
q9	7247	7238	7260	7238
q10	2983	3196	2747	2747
q11	569	500	498	498
q12	767	776	622	622
q13	4264	3910	3288	3288
q14	273	307	279	279
q15	520	464	471	464
q16	622	699	624	624
q17	1139	1538	1439	1439
q18	7648	7516	7386	7386
q19	833	818	838	818
q20	1979	2039	1849	1849
q21	5439	5085	4761	4761
q22	1092	1059	993	993
Total cold run time: 53339 ms
Total hot run time: 50587 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185134 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7f41ddc2aa3a3c5e69fef57c9ad78c99e8fb9301, data reload: false

query1	1015	394	367	367
query2	6525	1902	1866	1866
query3	6797	221	213	213
query4	26359	23304	23030	23030
query5	4316	651	497	497
query6	304	202	196	196
query7	4606	502	298	298
query8	303	249	240	240
query9	8592	2638	2621	2621
query10	480	308	262	262
query11	15954	15275	14952	14952
query12	154	112	111	111
query13	1671	528	401	401
query14	9553	6180	6179	6179
query15	203	194	177	177
query16	7230	646	471	471
query17	1196	718	565	565
query18	1957	409	324	324
query19	193	186	156	156
query20	124	119	119	119
query21	216	125	109	109
query22	4315	4264	4286	4264
query23	33972	32964	33125	32964
query24	8061	2349	2417	2349
query25	528	447	382	382
query26	1254	267	148	148
query27	2661	507	332	332
query28	4267	2452	2410	2410
query29	757	553	419	419
query30	282	221	214	214
query31	949	858	755	755
query32	71	67	63	63
query33	565	373	300	300
query34	779	837	494	494
query35	800	801	723	723
query36	957	1003	882	882
query37	125	95	75	75
query38	4198	4246	4139	4139
query39	1468	1400	1389	1389
query40	209	113	101	101
query41	56	51	51	51
query42	117	110	105	105
query43	484	479	461	461
query44	1272	778	779	778
query45	175	168	164	164
query46	846	1012	619	619
query47	1747	1819	1698	1698
query48	378	412	291	291
query49	764	495	415	415
query50	684	732	400	400
query51	4125	4192	4144	4144
query52	109	102	96	96
query53	233	256	193	193
query54	477	497	423	423
query55	83	80	80	80
query56	294	270	259	259
query57	1133	1138	1064	1064
query58	243	232	242	232
query59	2630	2639	2579	2579
query60	280	273	251	251
query61	125	122	120	120
query62	810	744	678	678
query63	231	185	182	182
query64	4367	1026	729	729
query65	4433	4338	4379	4338
query66	1149	410	296	296
query67	15825	15582	15299	15299
query68	8041	865	508	508
query69	460	295	259	259
query70	1189	1096	1178	1096
query71	478	283	277	277
query72	5603	3647	3779	3647
query73	776	732	349	349
query74	8927	9217	8829	8829
query75	3723	3150	2681	2681
query76	3692	1186	813	813
query77	822	364	276	276
query78	10195	10020	9301	9301
query79	2582	823	572	572
query80	633	516	442	442
query81	488	258	215	215
query82	624	127	95	95
query83	176	170	164	164
query84	238	88	75	75
query85	807	355	314	314
query86	394	329	281	281
query87	4539	4554	4253	4253
query88	3814	2258	2266	2258
query89	376	321	285	285
query90	1896	216	218	216
query91	141	142	118	118
query92	73	64	59	59
query93	1821	1068	574	574
query94	654	408	317	317
query95	359	276	273	273
query96	486	556	281	281
query97	3332	3397	3329	3329
query98	268	204	197	197
query99	1361	1389	1278	1278
Total cold run time: 276004 ms
Total hot run time: 185134 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7f41ddc2aa3a3c5e69fef57c9ad78c99e8fb9301, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.11
query5	0.56	0.55	0.58
query6	1.17	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.51	0.50
query10	0.57	0.61	0.59
query11	0.16	0.11	0.12
query12	0.14	0.11	0.11
query13	0.62	0.61	0.61
query14	2.69	2.69	2.70
query15	0.94	0.84	0.85
query16	0.37	0.37	0.39
query17	1.02	1.07	1.04
query18	0.21	0.19	0.19
query19	1.90	1.78	2.00
query20	0.01	0.01	0.01
query21	15.38	0.90	0.54
query22	0.77	1.07	0.72
query23	14.94	1.40	0.65
query24	6.82	1.31	1.11
query25	0.52	0.27	0.09
query26	0.51	0.16	0.14
query27	0.05	0.05	0.05
query28	10.23	0.92	0.44
query29	12.64	4.03	3.38
query30	0.25	0.09	0.06
query31	2.83	0.58	0.38
query32	3.23	0.55	0.47
query33	3.08	3.03	2.98
query34	15.84	5.14	4.53
query35	4.59	4.56	4.54
query36	0.67	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.15	0.15
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.02	0.03
Total cold run time: 105.82 s
Total hot run time: 31.29 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement TransactionBeginCommand in nereids
3 participants