Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud-mow) tablet_id should use int64_t to avoid truncation problem when removing old delete bitmap #43968

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[fix](cloud-mow) tablet_id should use int64_t to avoid truncation problem when removing old delete bitmap #43968

merged 1 commit into from
Nov 14, 2024

Conversation

hust-hhb
Copy link
Contributor

tablet_id is int64_t, use int32_t may have truncation problem, which will lead to send wrong tablet_id to ms, and do nothing on remove old delete bitmap
pick:#43956

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 27125e6 into apache:branch-3.0 Nov 14, 2024
26 of 28 checks passed
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@hust-hhb @gavinchou
[fix](cloud-mow) tablet_id should use int64_t to avoid truncation pro…
8403604 
…blem when removing old delete bitmap (apache#43968) (apache#43956)

tablet_id is int64_t, use int32_t may have truncation problem, which
will lead to send wrong tablet_id to ms, and do nothing on remove old
delete bitmap
pick:apache#43956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hust-hhb @doris-robot @zhannngchen @dataroaring