Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](function) fix cut_ipv6 function error about modify the input column data #43921

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

zhangstar333
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
cut_ipv6

the ipv6 function maybe need reverse the input ipv6 data, but can't do it at the input data
could copy to another data area process it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei yiguolei added usercase Important user case type label dev/2.1.x dev/3.0.x labels Nov 14, 2024
@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.93% (9885/26060)
Line Coverage: 29.14% (82629/283568)
Region Coverage: 28.26% (42455/150230)
Branch Coverage: 24.84% (21534/86678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1d1247680aca58e26436eaf68a7691bf9f26bb98_1d1247680aca58e26436eaf68a7691bf9f26bb98/report/index.html

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 18, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.97% (9897/26064)
Line Coverage: 29.16% (82712/283649)
Region Coverage: 28.30% (42482/150092)
Branch Coverage: 24.88% (21544/86594)
Coverage Report: http://coverage.selectdb-in.cc/coverage/614efab93d123e7748cdebb2bc23a263f814a5ff_614efab93d123e7748cdebb2bc23a263f814a5ff/report/index.html

@dataroaring dataroaring merged commit 03bc051 into apache:master Nov 18, 2024
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
…lumn data (#43921)

![cut_ipv6](https://github.com/user-attachments/assets/c4cde1d4-f812-4e25-bc45-c1e0e43ff08c)

the ipv6 function maybe need reverse the input ipv6 data, but can't do
it at the input data
could copy to another data area process it.
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
…lumn data (#43921)

![cut_ipv6](https://github.com/user-attachments/assets/c4cde1d4-f812-4e25-bc45-c1e0e43ff08c)

the ipv6 function maybe need reverse the input ipv6 data, but can't do
it at the input data
could copy to another data area process it.
dataroaring pushed a commit that referenced this pull request Nov 18, 2024
…the input column data #43921 (#44179)

Cherry-picked from #43921

Co-authored-by: zhangstar333 <[email protected]>
yiguolei pushed a commit that referenced this pull request Nov 19, 2024
…the input column data #43921 (#44180)

Cherry-picked from #43921

Co-authored-by: zhangstar333 <[email protected]>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants