Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [Optimize](Variant) move merge_rowsets_schema to sync_tablet_rowsets to make schema more accurate #43634

Merged
merged 1 commit into from
Nov 12, 2024
Merged

branch-3.0: [Optimize](Variant) move merge_rowsets_schema to sync_tablet_rowsets to make schema more accurate #43634

merged 1 commit into from
Nov 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #43580

@eldenmoon
[Optimize](Variant) move merge_rowsets_schema to sync_tablet_rowsets …
c6ecd30 
…to make schema more accurate (#43580)

Related PR: #42856 previous PR only merge schema in
`CloudTablet::sync_rowsets` but `CloudTablet:: sync_tablet_rowsets ` may
already done by other logic


Co-authored-by: eldenmoon <[email protected]>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

run buildall

1 similar comment
@eldenmoon
Copy link
Member

run buildall

@airborne12 airborne12 closed this Nov 12, 2024
@airborne12 airborne12 reopened this Nov 12, 2024
@eldenmoon eldenmoon merged commit 19ab0c2 into branch-3.0 Nov 12, 2024
21 of 23 checks passed
@eldenmoon eldenmoon deleted the auto-pick-43580-branch-3.0 branch November 12, 2024 02:04
@github-actions GitHub Actions
Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doris-robot @eldenmoon @airborne12