Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](Variant) avoid unnecessary mem for variant extracted columns #43567

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[opt](Variant) avoid unnecessary mem for variant extracted columns #43567

merged 1 commit into from
Nov 11, 2024
+8 −5

Conversation

eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Nov 11, 2024 •
edited
Loading

What problem does this PR solve?

_field_name_to_index and _field_id_to_index is unnecessary for variant subcolumns, since they use column path as identifier

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Sorry, something went wrong.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.91% (9866/26027)
Line Coverage: 29.08% (82241/282779)
Region Coverage: 28.24% (42340/149931)
Branch Coverage: 24.78% (21436/86494)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e1abab7a261a636e7858a3edb43654544e056e98_e1abab7a261a636e7858a3edb43654544e056e98/report/index.html

csun5285
csun5285 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit 7319d84 into apache:master Nov 11, 2024
25 of 28 checks passed
@eldenmoon eldenmoon deleted the var_ext-mem branch November 11, 2024 09:39
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
Loading
Loading status checks…
490c38e 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
Loading
Loading status checks…
0fd9050 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@eldenmoon eldenmoon mentioned this pull request Nov 11, 2024
Merged
eldenmoon added a commit that referenced this pull request Nov 11, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ff6ec6c 
…43567) (#43620)

(#43567)

Co-authored-by: eldenmoon <[email protected]>
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Nov 26, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
Loading
Loading status checks…
dcb70e0 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@eldenmoon eldenmoon mentioned this pull request Nov 26, 2024
Merged
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
yiguolei pushed a commit that referenced this pull request Nov 26, 2024
@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (#… (

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f88a816 
#44585)

cherry-pick from #43567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidaye qidaye

@csun5285 csun5285

Assignees
No one assigned
Labels
dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eldenmoon @doris-robot @qidaye @csun5285 @yiguolei