[enhancement](cloud) optimize block cache lock (#41818) #43401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pick apache#41818 from master 1. async deletion when do stale rowsets reclycle 2. minimize lock critical size 3. add cache lock held & wait time info for debug
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| #include <bvar/bvar.h> | |||
There was a problem hiding this comment.
warning: 'bvar/bvar.h' file not found [clang-diagnostic-error]
#include <bvar/bvar.h>
^| template <class Lock> | ||
| concept IsXLock = std::same_as<Lock, std::lock_guard<std::mutex>> || | ||
| std::same_as<Lock, std::unique_lock<std::mutex>>; | ||
|
|
||
| class FSFileCacheStorage; | ||
|
|
||
| class LockScopedTimer { | ||
| public: | ||
| LockScopedTimer() : start_(std::chrono::steady_clock::now()) {} |
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
Suggested change
| LockScopedTimer() : start_(std::chrono::steady_clock::now()) {} | |
| LockScopedTimer() : start_(std::chrono::steady_clock::now()) = default; |
TPC-H: Total hot run time: 40902 ms |
TPC-DS: Total hot run time: 190940 ms |
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 12, 2024
…#43401) pick apache#41818 from master 1. async deletion when do stale rowsets reclycle 2. minimize lock critical size 3. add cache lock held & wait time info for debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #41818 from master
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)