[Feat](Nereids) support string functions fold constant by fe #40441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38096 ms |
TPC-DS: Total hot run time: 192427 ms |
ClickBench: Total hot run time: 31.91 s |
|
run buildall |
LiBinfeng-01
force-pushed
the
fold_constants
branch
from
bd9dfc6 to
18f4a35
Compare
|
run buildall |
TPC-H: Total hot run time: 37836 ms |
TPC-DS: Total hot run time: 192562 ms |
ClickBench: Total hot run time: 32.23 s |
LiBinfeng-01
force-pushed
the
fold_constants
branch
from
18f4a35 to
297acb4
Compare
|
run buildall |
TPC-H: Total hot run time: 38399 ms |
TPC-DS: Total hot run time: 192774 ms |
ClickBench: Total hot run time: 31.66 s |
LiBinfeng-01
force-pushed
the
fold_constants
branch
from
297acb4 to
f560378
Compare
|
run buildall |
LiBinfeng-01
force-pushed
the
fold_constants
branch
from
f560378 to
54275d4
Compare
|
run buildall |
TPC-H: Total hot run time: 38006 ms |
|
run feut |
|
run buildall |
TPC-H: Total hot run time: 38078 ms |
TPC-DS: Total hot run time: 191376 ms |
ClickBench: Total hot run time: 31.75 s |
|
run buildall |
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 7, 2025
…re cases (apache#45233) Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases
Merged
16 tasks
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 7, 2025
…re cases (apache#45233) Issue Number: apache#44666 Related PR: apache#40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases
Merged
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Jan 9, 2025
…re cases (#45233) (#46525) pick: #45233 Issue Number: #44666 Related PR: #40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases --------- Co-authored-by: Mryange <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Jan 9, 2025
…s and add more cases #45233 (#46523) pick: #45233 Issue Number: #44666 Related PR: #40441 Problem Summary: - select substring_index('哈哈哈AAA','A', 1); String.split function has second parameter 'limit', which is default zero. When 'limit' is zero, it means it would remove trailing empty strings split of '哈哈哈AAA', which would be '哈哈哈' only. But what we expect is '哈哈哈', '','','' when part function is used by substring index. So we should change splitpart limit to -1 to enable trailing empty character in splitpart list - reorganize fold constant of string functions in fe and add more cases --------- Co-authored-by: Mryange <[email protected]>
16 tasks
This was referenced Mar 17, 2025
morrySnow
pushed a commit
that referenced
this pull request
Mar 21, 2025
…ter by mistake (#49087) ### What problem does this PR solve? Related PR: #40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
Merged
16 tasks
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Mar 21, 2025
…ter by mistake (apache#49087) Related PR: apache#40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
16 tasks
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Mar 21, 2025
…ter by mistake (apache#49087) Related PR: apache#40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
16 tasks
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Mar 21, 2025
…ter by mistake (apache#49087) Related PR: apache#40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Mar 21, 2025
…ter by mistake (apache#49087) Related PR: apache#40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
yiguolei
pushed a commit
that referenced
this pull request
Mar 21, 2025
…emoji character by mistake #49087 (#49344) pick: #49087 Related PR: #40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Mar 27, 2025
…emoji character by mistake #49087 (#49346) pick: #49087 Related PR: #40441 Problem Summary: wrong calculation of emoji character length in some String function when do constant folding in FE. For example: select STRLEFT('😊😉👍', 2); should return 😊😉, but fe return 😊 only when folding constant fixed functions: - left - strleft - right - strright - locate - character_length - split_by_string - overlay - replace_empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support string functions fold constant by fe:
Concat, Substring, Length, Lower, Upper, Trim, Ltrim, Rtrim, Replace, Left, Right, Locate,
Instr, Ascii, Bin, ConcatWs, CharacterLength, Initcap, Md5, Md5Sum,
Field, FindInSet, Repeat, Reverse, Space, SplitByChar, SplitByString, SplitPart,
SubstringIndex, Strcmp, StrLeft, StrRight, Overlay, ParseUrl, UrlDecode,
AppendTrailingCharIfAbsent, EndsWith, ExtractUrlParameter, Quote, ReplaceEmpty, Password