[fix](Nereids) fix fold constant by be return type mismatched #39723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38325 ms |
TPC-DS: Total hot run time: 186767 ms |
ClickBench: Total hot run time: 30.5 s |
englefly
previously approved these changes
Aug 27, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
reviewed
Aug 28, 2024
| @@ -176,7 +176,11 @@ private static Expression replace( | |||
| if (newChild != child) { | |||
| hasNewChildren = true; | |||
| } | |||
| newChildren.add(newChild); | |||
| if (newChild.getDataType() != child.getDataType()) { | |||
LiBinfeng-01
force-pushed
the
fix_fold_const_be_type
branch
from
137723b to
de3e82d
Compare
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 43468 ms |
TPC-DS: Total hot run time: 195649 ms |
ClickBench: Total hot run time: 30.88 s |
LiBinfeng-01
force-pushed
the
fix_fold_const_be_type
branch
from
de3e82d to
5b9da22
Compare
|
run buildall |
TPC-H: Total hot run time: 41904 ms |
TPC-DS: Total hot run time: 199436 ms |
ClickBench: Total hot run time: 32.36 s |
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 42028 ms |
TPC-DS: Total hot run time: 194730 ms |
ClickBench: Total hot run time: 32.76 s |
morrySnow
approved these changes
Sep 19, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
englefly
approved these changes
Sep 19, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 8, 2024
…#39723) when using fold constant by be, the return type of substring('123456', 1, 3) would changed to be text, which we want it to be 3
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
when using fold constant by be, the return type of substring('123456',
1, 3) would changed to be text, which we want it to be 3
morrySnow
pushed a commit
that referenced
this pull request
Oct 14, 2024
…#41164) (#41537) cherry-pick: #39723 #41164 because later problem is intro by prev one, so put them together when using fold constant by be, the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 15, 2024
…#39723)(apache#41164) (apache#41537) cherry-pick: apache#39723 apache#41164 because later problem is intro by prev one, so put them together when using fold constant by be, the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Oct 17, 2024
…#39723)(apache#41164) (apache#41537) cherry-pick: apache#39723 apache#41164 because later problem is intro by prev one, so put them together when using fold constant by be, the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
924060929
pushed a commit
that referenced
this pull request
Oct 18, 2024
…#41164)(#41331)(#41546) (#41838) cherry-pick: #39723 #41164 #41331 #41546 because later problem is intro by prev one, so put them together when using fold constant by be, the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using fold constant by be, the return type of substring('123456', 1, 3) would changed to be text, which we want it to be 3