[fix](mtmv) Fix rewrite fail when query direct external table without group by #39041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 41859 ms |
TPC-DS: Total hot run time: 168970 ms |
ClickBench: Total hot run time: 30.09 s |
morrySnow
previously approved these changes
Aug 9, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
seawinde
force-pushed
the
fix_direct_query_external_table_not_hit
branch
from
425a345 to
ab361f9
Compare
|
run buildall |
TPC-H: Total hot run time: 38238 ms |
TPC-DS: Total hot run time: 196815 ms |
ClickBench: Total hot run time: 31.64 s |
seawinde
force-pushed
the
fix_direct_query_external_table_not_hit
branch
from
ab361f9 to
0aa507a
Compare
|
run buildall |
TPC-H: Total hot run time: 37990 ms |
TPC-H: Total hot run time: 38516 ms |
TPC-DS: Total hot run time: 191103 ms |
ClickBench: Total hot run time: 31.57 s |
morrySnow
approved these changes
Aug 20, 2024
starocean999
approved these changes
Aug 20, 2024
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 21, 2024
… group by (apache#39041) this is brought by apache#34185 if query external table without group by, rewrite by materialized view will fail such as mv def is select o_custkey, o_orderdate from ${hive_catalog_name}.${hive_database}.${hive_table}; query is query external table directly as following, this would fail when try to rewrte by materialized view select o_custkey from ${hive_catalog_name}.${hive_database}.${hive_table}; this pr fix the problem.
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
… group by (#39041) this is brought by #34185 if query external table without group by, rewrite by materialized view will fail such as mv def is select o_custkey, o_orderdate from ${hive_catalog_name}.${hive_database}.${hive_table}; query is query external table directly as following, this would fail when try to rewrte by materialized view select o_custkey from ${hive_catalog_name}.${hive_database}.${hive_table}; this pr fix the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this is brought by #34185
if query external table without group by, rewrite by materialized view will fail
such as mv def is
query is query external table directly as following, this would fail when try to rewrte by materialized view
this pr fix the problem.