Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhance](auth)modify priv of refresh catalog/db/table #39008

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[enhance](auth)modify priv of refresh catalog/db/table #39008

merged 2 commits into from
Aug 12, 2024

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Aug 7, 2024

change priv of refresh catalog/db/table to PrivPredicate.SHOW

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr zddr changed the title [enhance]modify priv of refresh catalog/db/table [enhance](auth)modify priv of refresh catalog/db/table Aug 7, 2024
@zddr
Copy link
Contributor Author

zddr commented Aug 7, 2024

run buildall

@github-actions github-actions bot added the doing label Aug 7, 2024
morningman
morningman previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by anyone and no changes requested.

@zddr
Copy link
Contributor Author

zddr commented Aug 7, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@morrySnow morrySnow removed the doing label Aug 7, 2024
@morningman morningman force-pushed the refresh_catalog_auth branch from f637112 to eb29acf Compare August 9, 2024 05:58
@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the doing label Aug 9, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39191 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eb29acf4041708bf44f9f357b441417ee046b025, data reload: false

------ Round 1 ----------------------------------
q1	17627	4360	4265	4265
q2	2020	181	178	178
q3	10475	1145	1086	1086
q4	10136	696	716	696
q5	7518	2484	2463	2463
q6	223	137	137	137
q7	980	590	594	590
q8	9227	1896	1852	1852
q9	8622	6530	6550	6530
q10	7049	2188	2201	2188
q11	475	241	246	241
q12	433	214	210	210
q13	18221	2975	2993	2975
q14	279	238	235	235
q15	517	485	485	485
q16	506	396	375	375
q17	956	675	623	623
q18	7969	7415	7407	7407
q19	5194	967	975	967
q20	679	326	320	320
q21	5406	4374	4465	4374
q22	1093	1005	994	994
Total cold run time: 115605 ms
Total hot run time: 39191 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4391	4242	4250	4242
q2	365	281	288	281
q3	2780	2584	2602	2584
q4	1966	1642	1642	1642
q5	5493	5613	5421	5421
q6	215	128	127	127
q7	2110	1746	1692	1692
q8	3273	3447	3391	3391
q9	8778	8661	8815	8661
q10	3509	3225	3320	3225
q11	605	512	502	502
q12	750	601	613	601
q13	15859	3135	3182	3135
q14	309	292	303	292
q15	533	505	494	494
q16	488	433	430	430
q17	1841	1538	1517	1517
q18	8078	7886	7797	7797
q19	1801	1587	1608	1587
q20	2121	1896	1870	1870
q21	5553	5307	5421	5307
q22	1096	994	969	969
Total cold run time: 71914 ms
Total hot run time: 55767 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204390 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eb29acf4041708bf44f9f357b441417ee046b025, data reload: false

query1	947	406	389	389
query2	6448	1954	1959	1954
query3	6629	205	221	205
query4	34282	23209	23153	23153
query5	3661	493	502	493
query6	279	187	182	182
query7	4573	301	307	301
query8	246	203	197	197
query9	8350	2481	2451	2451
query10	963	916	885	885
query11	17702	15114	14933	14933
query12	131	95	94	94
query13	1628	384	364	364
query14	10344	7998	8312	7998
query15	393	307	318	307
query16	7816	486	462	462
query17	1715	583	573	573
query18	1998	408	395	395
query19	255	196	189	189
query20	114	113	113	113
query21	203	102	106	102
query22	4480	4352	4399	4352
query23	34548	34942	33805	33805
query24	11220	2895	2802	2802
query25	493	382	371	371
query26	712	154	148	148
query27	2430	284	280	280
query28	6669	2033	2007	2007
query29	632	402	398	398
query30	258	154	148	148
query31	980	768	757	757
query32	100	52	52	52
query33	716	277	281	277
query34	874	468	468	468
query35	976	829	828	828
query36	1078	913	920	913
query37	136	80	82	80
query38	4214	4167	4065	4065
query39	1441	1366	1380	1366
query40	196	114	112	112
query41	47	46	43	43
query42	117	98	93	93
query43	513	482	464	464
query44	1237	739	736	736
query45	392	381	379	379
query46	1116	780	779	779
query47	1847	1754	1768	1754
query48	385	314	345	314
query49	838	413	435	413
query50	811	410	417	410
query51	6802	6752	6639	6639
query52	99	88	91	88
query53	247	180	177	177
query54	923	445	453	445
query55	78	72	74	72
query56	264	244	248	244
query57	1121	1029	1054	1029
query58	228	222	239	222
query59	3169	2805	2876	2805
query60	291	253	266	253
query61	102	96	96	96
query62	781	660	620	620
query63	207	176	184	176
query64	9614	2445	1939	1939
query65	3195	3138	3167	3138
query66	684	324	349	324
query67	15405	14973	14923	14923
query68	4555	556	557	556
query69	406	410	376	376
query70	1097	1107	1128	1107
query71	411	272	273	272
query72	17367	16852	16773	16773
query73	750	338	331	331
query74	9057	8762	8752	8752
query75	3364	2640	2701	2640
query76	2659	1092	944	944
query77	439	299	310	299
query78	9598	9165	9035	9035
query79	2625	511	527	511
query80	2061	489	487	487
query81	605	228	225	225
query82	950	134	139	134
query83	312	150	164	150
query84	265	80	78	78
query85	1728	315	302	302
query86	416	305	303	303
query87	4714	4560	4567	4560
query88	4133	2488	2503	2488
query89	392	276	280	276
query90	1703	208	190	190
query91	142	121	133	121
query92	60	52	50	50
query93	2444	539	544	539
query94	737	300	293	293
query95	361	274	271	271
query96	608	285	276	276
query97	3280	3084	3066	3066
query98	227	207	281	207
query99	1562	1248	1234	1234
Total cold run time: 310371 ms
Total hot run time: 204390 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eb29acf4041708bf44f9f357b441417ee046b025, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.04	0.04
query4	1.69	0.08	0.08
query5	0.50	0.49	0.50
query6	1.13	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.55	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.58
query14	0.77	0.78	0.80
query15	0.85	0.82	0.82
query16	0.38	0.35	0.37
query17	1.05	0.98	0.98
query18	0.24	0.24	0.22
query19	1.86	1.68	1.70
query20	0.01	0.01	0.01
query21	15.41	0.74	0.65
query22	4.01	7.25	2.58
query23	18.29	1.29	1.30
query24	2.16	0.23	0.22
query25	0.16	0.09	0.08
query26	0.30	0.22	0.22
query27	0.45	0.23	0.22
query28	13.22	1.02	0.99
query29	12.59	3.53	3.53
query30	0.24	0.05	0.05
query31	2.92	0.40	0.39
query32	3.27	0.48	0.46
query33	2.93	2.86	2.88
query34	17.14	4.33	4.41
query35	4.42	4.48	4.41
query36	0.65	0.48	0.50
query37	0.18	0.17	0.15
query38	0.16	0.14	0.14
query39	0.04	0.04	0.04
query40	0.17	0.12	0.13
query41	0.09	0.04	0.04
query42	0.05	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.78 s
Total hot run time: 31.46 s

morningman
morningman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit d91a7ad into apache:master Aug 12, 2024
29 of 30 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@zddr @wyxxxcat
[enhance](auth)modify priv of refresh catalog/db/table (apache#39008)
832cafd 
change priv of refresh catalog/db/table to `PrivPredicate.SHOW`
zddr added a commit to zddr/incubator-doris that referenced this pull request Aug 16, 2024
@zddr
[enhance](auth)modify priv of refresh catalog/db/table (apache#39008)
6cf3680 
change priv of refresh catalog/db/table to `PrivPredicate.SHOW`
@zddr zddr mentioned this pull request Aug 16, 2024
Merged
morrySnow pushed a commit that referenced this pull request Aug 16, 2024
@zddr
[enhance](auth)modify priv of refresh catalog/db/table (#39008) (#39475)
f203ee8 
pick from master #39008
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@zddr @dataroaring
[enhance](auth)modify priv of refresh catalog/db/table (#39008)
467c2fa 
change priv of refresh catalog/db/table to `PrivPredicate.SHOW`
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged doing kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zddr @doris-robot @morningman @morrySnow @dataroaring