[feature](cast) Support cast complex type to json #36548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/amorynan/doris into support-cast-complex-type-to-json
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morrySnow
changed the title
|
run buildall |
morrySnow
reviewed
Jun 19, 2024
| @@ -834,6 +834,10 @@ public static boolean isImplicitlyCastable(Type t1, Type t2, boolean strict, boo | |||
| } | |||
|
|
|||
| public static boolean canCastTo(Type sourceType, Type targetType) { | |||
| // In BE Code , we make any data type can cast to jsonb | |||
| if (targetType.isJsonbType()) { | |||
| return true; | |||
There was a problem hiding this comment.
agg_state, variant could cast to json? what we will get if cast ipv4 /ipv6 to json.
| @@ -834,6 +834,10 @@ public static boolean isImplicitlyCastable(Type t1, Type t2, boolean strict, boo | |||
| } | |||
|
|
|||
| public static boolean canCastTo(Type sourceType, Type targetType) { | |||
| // In BE Code , we make any data type can cast to jsonb | |||
| if (targetType.isJsonbType()) { | |||
| return true; | |||
There was a problem hiding this comment.
if support all type, u should add all type cast to json test case
Comment on lines
123
to
131
| if (complexType.isMapType()) { | ||
| return ((MapType) complexType).getKeyType().isStringType(); | ||
| } else if (complexType.isArrayType()) { | ||
| return checkMapKeyIsStringLikeForJson(((ArrayType) complexType).getItemType()); | ||
| } else if (complexType.isStructType()) { | ||
| for (StructField f : ((StructType) complexType).getFields()) { | ||
| return checkMapKeyIsStringLikeForJson(f.getType()); | ||
| } | ||
| } |
There was a problem hiding this comment.
should check in nereids, not here
TPC-H: Total hot run time: 39887 ms |
TPC-DS: Total hot run time: 172075 ms |
|
run buildall |
|
run buildall |
morrySnow
approved these changes
Jun 20, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39579 ms |
TPC-DS: Total hot run time: 173087 ms |
ClickBench: Total hot run time: 30.49 s |
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2024
support cast complex type to json which we can use array_agg/map_agg result into json_object
yiguolei
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Proposed changes backport: #36548 Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
in this pr we do
Issue Number: close #xxx