Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](hive)Misspelling of class names #34981

Merged
merged 4 commits into from
May 27, 2024
Merged

[bugfix](hive)Misspelling of class names #34981

merged 4 commits into from
May 27, 2024

Conversation

wuwenchi
Copy link
Contributor

Proposed changes

Issue Number: close #34944

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ixzc ixzc mentioned this pull request May 17, 2024
Closed
3 tasks
@morningman
Copy link
Contributor

I will merge it first quickly and add regression test later

morningman
morningman previously approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

kaka11chen
kaka11chen approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuwenchi
Copy link
Contributor Author

run p0

@wuwenchi wuwenchi force-pushed the fix-parquet-format-error branch from 96a73b6 to 696e7a0 Compare May 21, 2024 02:17
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 21, 2024
@wuwenchi
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@wuwenchi
Copy link
Contributor Author

run p0

1 similar comment
@wuwenchi
Copy link
Contributor Author

run p0

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39843 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e6b620f5455c78f5a6b91a4e3d6f7ea6af7f26d9, data reload: false

------ Round 1 ----------------------------------
q1	18010	4417	4330	4330
q2	3022	202	205	202
q3	11025	1247	1175	1175
q4	11623	796	770	770
q5	7718	2697	2781	2697
q6	223	132	136	132
q7	965	596	599	596
q8	9219	2060	2049	2049
q9	8737	6431	6428	6428
q10	8821	3626	3715	3626
q11	447	250	237	237
q12	440	228	216	216
q13	17765	3012	2949	2949
q14	259	225	220	220
q15	505	488	474	474
q16	529	389	381	381
q17	960	689	733	689
q18	8061	7522	7447	7447
q19	7707	1567	1503	1503
q20	655	310	307	307
q21	4904	3142	3264	3142
q22	350	282	273	273
Total cold run time: 121945 ms
Total hot run time: 39843 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4308	4203	4162	4162
q2	362	280	271	271
q3	2977	2810	2722	2722
q4	1914	1610	1631	1610
q5	5279	5268	5298	5268
q6	211	122	126	122
q7	2125	1728	1734	1728
q8	3148	3306	3275	3275
q9	8366	8348	8330	8330
q10	3859	3692	3751	3692
q11	582	498	503	498
q12	758	615	576	576
q13	16352	2985	2966	2966
q14	295	273	268	268
q15	512	469	483	469
q16	484	420	453	420
q17	1762	1495	1465	1465
q18	7630	7572	7318	7318
q19	1642	1586	1552	1552
q20	1968	1821	1777	1777
q21	4841	4703	4672	4672
q22	580	507	490	490
Total cold run time: 69955 ms
Total hot run time: 53651 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168580 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e6b620f5455c78f5a6b91a4e3d6f7ea6af7f26d9, data reload: false

query1	909	387	363	363
query2	6452	2430	2384	2384
query3	6651	207	203	203
query4	19711	17486	17291	17291
query5	4224	411	416	411
query6	257	160	156	156
query7	4599	300	291	291
query8	236	181	173	173
query9	8536	2478	2448	2448
query10	449	287	262	262
query11	10704	10107	10114	10107
query12	128	88	87	87
query13	1629	358	347	347
query14	9376	7545	6154	6154
query15	201	170	173	170
query16	7551	266	252	252
query17	1857	527	509	509
query18	1416	301	269	269
query19	192	158	153	153
query20	98	90	91	90
query21	200	139	129	129
query22	4253	4073	3819	3819
query23	33716	32876	33381	32876
query24	12067	2888	2791	2791
query25	671	355	359	355
query26	1653	153	152	152
query27	3075	319	315	315
query28	7712	2077	2079	2077
query29	1032	604	596	596
query30	300	174	174	174
query31	958	754	747	747
query32	88	51	52	51
query33	770	304	260	260
query34	990	469	472	469
query35	718	587	590	587
query36	1084	887	875	875
query37	283	69	72	69
query38	2874	2771	2751	2751
query39	846	786	784	784
query40	272	120	124	120
query41	46	44	45	44
query42	104	93	95	93
query43	570	567	544	544
query44	1166	707	747	707
query45	176	158	155	155
query46	1077	718	715	715
query47	1828	1744	1782	1744
query48	374	291	295	291
query49	1189	403	407	403
query50	759	379	395	379
query51	6853	6629	6676	6629
query52	96	92	87	87
query53	352	284	277	277
query54	860	435	419	419
query55	73	75	73	73
query56	255	240	242	240
query57	1155	1061	1060	1060
query58	237	209	207	207
query59	3450	3056	3250	3056
query60	275	254	250	250
query61	99	97	114	97
query62	664	469	465	465
query63	313	314	277	277
query64	9827	2177	1721	1721
query65	3155	3086	3114	3086
query66	1292	331	336	331
query67	15518	14908	14978	14908
query68	4460	531	544	531
query69	452	280	281	280
query70	1186	1059	1147	1059
query71	385	273	266	266
query72	7680	5689	2881	2881
query73	715	326	327	326
query74	6042	5601	5596	5596
query75	3268	2642	2655	2642
query76	2703	1020	984	984
query77	427	271	269	269
query78	10441	9779	9600	9600
query79	2616	514	512	512
query80	1995	458	455	455
query81	539	241	241	241
query82	752	104	103	103
query83	278	185	196	185
query84	278	91	94	91
query85	2069	333	319	319
query86	483	294	308	294
query87	3297	3067	3095	3067
query88	4222	2425	2423	2423
query89	481	399	379	379
query90	1972	195	186	186
query91	138	108	113	108
query92	62	49	51	49
query93	3729	510	503	503
query94	1286	195	194	194
query95	407	314	321	314
query96	606	266	275	266
query97	3172	3019	3007	3007
query98	249	226	217	217
query99	1230	858	884	858
Total cold run time: 278121 ms
Total hot run time: 168580 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e6b620f5455c78f5a6b91a4e3d6f7ea6af7f26d9, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.07	0.06
query4	1.66	0.07	0.07
query5	0.51	0.51	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.48	0.49
query10	0.56	0.55	0.53
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.58	0.58	0.60
query14	0.78	0.76	0.78
query15	0.83	0.81	0.80
query16	0.36	0.37	0.35
query17	0.93	0.97	0.96
query18	0.24	0.23	0.24
query19	1.74	1.71	1.71
query20	0.01	0.01	0.01
query21	15.71	0.66	0.66
query22	4.35	7.44	1.95
query23	18.26	1.37	1.31
query24	1.35	0.42	0.20
query25	0.14	0.08	0.08
query26	0.28	0.16	0.16
query27	0.08	0.08	0.08
query28	13.36	1.01	1.00
query29	12.81	3.32	3.27
query30	0.25	0.06	0.06
query31	2.85	0.40	0.38
query32	3.31	0.47	0.47
query33	2.83	2.90	2.92
query34	17.09	4.37	4.45
query35	4.47	4.47	4.45
query36	0.65	0.46	0.46
query37	0.18	0.15	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.15	0.14
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.1 s
Total hot run time: 30.49 s

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41739 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 346c6206cecc5b511b214293987f0fd4a6df28db, data reload: false

------ Round 1 ----------------------------------
q1	17593	4229	4216	4216
q2	2026	185	183	183
q3	10465	1242	1258	1242
q4	10198	839	859	839
q5	7481	2701	2677	2677
q6	220	132	135	132
q7	948	616	605	605
q8	9253	2121	2087	2087
q9	9792	6624	6697	6624
q10	9044	3882	3866	3866
q11	463	240	226	226
q12	451	220	237	220
q13	18548	3245	3175	3175
q14	262	237	223	223
q15	521	483	463	463
q16	517	397	387	387
q17	946	687	659	659
q18	8422	7826	7782	7782
q19	5645	1560	1581	1560
q20	649	303	308	303
q21	5069	3999	4180	3999
q22	349	287	271	271
Total cold run time: 118862 ms
Total hot run time: 41739 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4524	4325	4353	4325
q2	380	267	275	267
q3	3153	2877	2870	2870
q4	1957	1639	1583	1583
q5	5363	5462	5468	5462
q6	221	121	123	121
q7	2172	1872	1817	1817
q8	3247	3406	3383	3383
q9	8616	8675	8639	8639
q10	4066	3786	3714	3714
q11	577	494	492	492
q12	806	646	622	622
q13	17063	3159	3157	3157
q14	304	275	265	265
q15	536	469	483	469
q16	501	428	436	428
q17	1825	1534	1522	1522
q18	7843	7554	7404	7404
q19	1640	1560	1602	1560
q20	1991	1787	1801	1787
q21	8667	4822	4712	4712
q22	560	493	499	493
Total cold run time: 76012 ms
Total hot run time: 55092 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168367 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 346c6206cecc5b511b214293987f0fd4a6df28db, data reload: false

query1	914	383	373	373
query2	6436	2316	2256	2256
query3	6640	204	208	204
query4	19114	17707	17387	17387
query5	4093	427	423	423
query6	239	155	157	155
query7	4591	282	285	282
query8	234	190	179	179
query9	8512	2371	2351	2351
query10	457	286	257	257
query11	10374	10182	10083	10083
query12	144	88	91	88
query13	1646	364	370	364
query14	10075	6874	7501	6874
query15	219	172	175	172
query16	7801	268	271	268
query17	1763	521	504	504
query18	1969	266	267	266
query19	194	147	147	147
query20	91	82	81	81
query21	196	132	127	127
query22	4079	4126	3908	3908
query23	33654	32741	32960	32741
query24	10460	2853	2872	2853
query25	577	362	369	362
query26	707	154	155	154
query27	2214	318	328	318
query28	5899	2060	2045	2045
query29	859	601	588	588
query30	260	169	170	169
query31	947	744	761	744
query32	102	53	55	53
query33	659	267	278	267
query34	883	475	490	475
query35	733	622	581	581
query36	1053	914	891	891
query37	110	71	68	68
query38	2873	2751	2745	2745
query39	851	777	767	767
query40	196	121	121	121
query41	46	43	42	42
query42	104	94	94	94
query43	550	532	555	532
query44	1058	723	730	723
query45	182	166	161	161
query46	1078	722	688	688
query47	1846	1739	1787	1739
query48	379	287	296	287
query49	858	395	390	390
query50	777	376	403	376
query51	6911	6692	6667	6667
query52	99	89	86	86
query53	344	282	288	282
query54	858	420	415	415
query55	75	73	72	72
query56	255	243	241	241
query57	1111	1024	1057	1024
query58	231	205	206	205
query59	3509	3414	3090	3090
query60	293	251	244	244
query61	90	84	119	84
query62	609	435	436	435
query63	306	292	288	288
query64	8450	2171	1687	1687
query65	3160	3059	3098	3059
query66	797	323	325	323
query67	15069	14904	14673	14673
query68	4472	528	533	528
query69	489	263	264	263
query70	1133	1054	1117	1054
query71	373	267	266	266
query72	7431	2754	2547	2547
query73	733	329	323	323
query74	5974	5570	5567	5567
query75	3321	2589	2627	2589
query76	2328	998	1023	998
query77	402	260	263	260
query78	10094	9965	9804	9804
query79	2591	508	507	507
query80	1065	434	424	424
query81	549	244	242	242
query82	755	97	92	92
query83	249	169	173	169
query84	246	92	93	92
query85	1459	312	347	312
query86	479	317	305	305
query87	3313	3106	3106	3106
query88	4231	2340	2318	2318
query89	489	418	376	376
query90	2031	187	192	187
query91	126	98	94	94
query92	61	50	47	47
query93	1882	515	496	496
query94	1201	189	191	189
query95	393	319	309	309
query96	582	271	264	264
query97	3141	2960	2998	2960
query98	234	217	221	217
query99	1168	887	864	864
Total cold run time: 264858 ms
Total hot run time: 168367 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 346c6206cecc5b511b214293987f0fd4a6df28db, data reload: false

query1	0.04	0.03	0.04
query2	0.09	0.04	0.05
query3	0.23	0.05	0.05
query4	1.69	0.06	0.07
query5	0.48	0.49	0.49
query6	1.12	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.54	0.49	0.49
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.14	0.11	0.11
query13	0.59	0.58	0.59
query14	0.79	0.78	0.76
query15	0.82	0.82	0.81
query16	0.36	0.37	0.37
query17	1.02	0.98	0.98
query18	0.20	0.25	0.25
query19	1.76	1.74	1.77
query20	0.02	0.01	0.01
query21	15.55	0.67	0.64
query22	3.91	7.56	1.78
query23	18.29	1.37	1.25
query24	1.77	0.26	0.23
query25	0.13	0.08	0.09
query26	0.26	0.16	0.16
query27	0.09	0.08	0.09
query28	13.26	1.01	1.00
query29	13.76	3.34	3.27
query30	0.23	0.06	0.05
query31	2.87	0.37	0.38
query32	3.30	0.46	0.46
query33	2.85	2.96	2.89
query34	17.06	4.48	4.46
query35	4.50	4.54	4.63
query36	0.66	0.48	0.46
query37	0.18	0.16	0.15
query38	0.14	0.15	0.16
query39	0.04	0.04	0.04
query40	0.16	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.03	0.04	0.04
Total cold run time: 109.83 s
Total hot run time: 30.51 s

kaka11chen
kaka11chen approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit c72a495 into apache:master May 27, 2024
27 of 28 checks passed
dataroaring pushed a commit that referenced this pull request May 27, 2024
@wuwenchi @dataroaring
[bugfix](hive)Misspelling of class names (#34981)
6edf27e
yiguolei pushed a commit that referenced this pull request May 27, 2024
@wuwenchi @Doris-Extras
[bugfix](hive)Misspelling of class names (#34981)
f98ed4e
seawinde pushed a commit to seawinde/doris that referenced this pull request May 27, 2024
@wuwenchi @seawinde
[bugfix](hive)Misspelling of class names (apache#34981)
6a73dd7
@morningman morningman mentioned this pull request Jun 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat
5 participants
@wuwenchi @doris-robot @morningman @kaka11chen @gavinchou