Add sdf kafka poll latencies #34275
Open
Add sdf kafka poll latencies #34275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
scwhittle
requested changes
Mar 13, 2025
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
Outdated
Show resolved
Hide resolved
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
Outdated
Show resolved
Hide resolved
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java
Outdated
Show resolved
Hide resolved
Naireen
force-pushed
the
add_sdf_kafka_poll_latencies
branch
from
6f9eb14 to
31585e7
Compare
|
Run Java PreCommit |
scwhittle
requested changes
Mar 14, 2025
| rawRecords = poll(consumer, kafkaSourceDescriptor.getTopicPartition()); | ||
| KafkaMetrics kafkaMetrics = KafkaSinkMetrics.kafkaMetrics(); | ||
| rawRecords = poll(consumer, kafkaSourceDescriptor.getTopicPartition(), kafkaMetrics); | ||
| kafkaMetrics.flushBufferedMetrics(); |
There was a problem hiding this comment.
what about not flushing here and just falling through?
would it be ok to just flush once outside the while loop with a try { } finally { kafkaMetrics.flushBufferedMetrics(); } block?
There was a problem hiding this comment.
I didn't do it because of the returns, but apparently the finally block will run and then return, so that will work. I have modified the code.
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sdf poll metrics to kafka for runner v2
Should be merged after #34244
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.