Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Move make_builder into mod.rs #7218

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@lewiszlw lewiszlw changed the title Move make_builder into mod.rs Move make_builder into mod.rs Feb 28, 2025
@alamb
Copy link
Contributor

alamb commented Mar 6, 2025

Thanks for this contribution @lewiszlw -- what is the rationale / reason for this proposed change?

@lewiszlw
Copy link
Member Author

Because make_builder function can make array builders for all data types. It looks a bit unreasonable that putting it in struct_builder.rs file. @alamb

@alamb alamb changed the title Move make_builder into mod.rs Minor: Move make_builder into mod.rs Mar 11, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup @lewiszlw

I double checked that this doesn't change the module location of make_builder (it is still in arrow_array) and thus that this is not a breaking API change

Screenshot 2025-03-11 at 1 42 52 PM
Screenshot 2025-03-11 at 1 42 58 PM

@alamb alamb merged commit 936dc59 into apache:main Mar 14, 2025
27 of 28 checks passed
PinkCrow007 pushed a commit to PinkCrow007/arrow-rs that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants