Remove some top-level imports to airflow.sdk from Core airflow. #47785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Mar 14, 2025
This removes anything from the import path in the Execution API, which was failing to load when building the sdk's datamodels/_generated.py. It would be nice to add a ruff rule to enforce this, but while `airflow/` is still in the top level (and not in a subproject) it's a lot of work to do this without needint go exclude it from _every_ providers rules. So I'm doing this right now with the knowledge that this is a game of whack-a-mole.
ashb
force-pushed
the
remove-top-level-sdk-imports-from-core
branch
from
9bc593f to
58bffb2
Compare
eladkal
approved these changes
Mar 14, 2025
jedcunningham
approved these changes
Mar 14, 2025
|
It will be heck easier after #47798 |
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
…he#47785) This removes anything from the import path in the Execution API, which was failing to load when building the sdk's datamodels/_generated.py. It would be nice to add a ruff rule to enforce this, but while `airflow/` is still in the top level (and not in a subproject) it's a lot of work to do this without needint go exclude it from _every_ providers rules. So I'm doing this right now with the knowledge that this is a game of whack-a-mole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes anything from the import path in the Execution API, which was
failing to load when building the sdk's datamodels/_generated.py.
It would be nice to add a ruff rule to enforce this, but while
airflow/isstill in the top level (and not in a subproject) it's a lot of work to do this
without needint go exclude it from every providers rules.
So I'm doing this right now with the knowledge that this is a game of
whack-a-mole.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.