Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong layout names in layouts/types.ts #6783

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Crystal-RainSlide
Copy link
Contributor

Copy link

Walkthrough

This pull request addresses incorrect layout type names in the layouts/types.ts file. The changes involve correcting the naming conventions for layout types to ensure consistency and accuracy with the documented standards.

Changes

File Summary
packages/g6/src/layouts/types.ts Corrected layout type names from 'fruchtermanGPU' to 'fruchterman-gpu' and 'forceAtlas2' to 'force-atlas2'.

@@ -99,7 +99,7 @@ interface RadialLayout extends BaseLayoutOptions, RadialLayoutOptions {
}

interface FruchtermanLayout extends BaseLayoutOptions, FruchtermanLayoutOptions {
type: 'fruchterman' | 'fruchtermanGPU';
type: 'fruchterman' | 'fruchterman-gpu';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that all references to 'fruchtermanGPU' are updated to 'fruchterman-gpu' throughout the codebase to avoid inconsistencies.

@@ -115,7 +115,7 @@ interface ForceLayout extends BaseLayoutOptions, ForceLayoutOptions {
}

interface ForceAtlas2 extends BaseLayoutOptions, ForceAtlas2LayoutOptions {
type: 'forceAtlas2';
type: 'force-atlas2';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that all references to 'forceAtlas2' are updated to 'force-atlas2' throughout the codebase to avoid inconsistencies.

@Aarebecca Aarebecca merged commit f6627e7 into antvis:v5 Feb 19, 2025
2 checks passed
@Crystal-RainSlide Crystal-RainSlide deleted the fix-type-layout-name branch February 20, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants