feat: add parameter config support to layout function #6762
+2,741
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces parameter configuration support to the layout function in the G6 library. It modifies the layout execution to accept optional layout options, enhancing flexibility in layout customization. Additionally, it updates tests and examples to reflect these changes. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| * @apiCategory layout | ||
| */ | ||
| public async layout() { | ||
| await this.context.layout!.postLayout(); | ||
| public async layout(layoutOptions?: LayoutOptions) { |
There was a problem hiding this comment.
The change in the layout method signature to accept layoutOptions is a critical update. Ensure that all calls to this method across the codebase are updated to handle this optional parameter to avoid potential runtime errors.
Aarebecca
reviewed
Feb 10, 2025
|
有关联的 issue 吗？ |
这个目前没有对应 issue，是 25 年规划里的一项，这个需要提个 issue 绑定上不 |
Aarebecca
approved these changes
Feb 10, 2025
如果就关联一下，没有就不需要了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to configure the
layoutOptionsparameter when calling thelayoutfunction to perform the layout, and this layout will not modify the default configuration.