docs: support user feedback on G6 site #6742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yvonneyx
commented
Jan 23, 2025
•
yvonneyx
commented
- Allow users to provide feedback directly on the G6 official website
WalkthroughThis pull request introduces changes to the G6 site to allow users to provide feedback directly on the official website. It includes updates to configuration files and enhancements to the markdown emitter and document page title components to support this new feature. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
|
|
||
| public constructor(parameters: IDocPageTitleParameters) { | ||
| super(parameters); | ||
| this.title = parameters.title; | ||
| this.order = parameters.order; | ||
| this.readonly = true; |
There was a problem hiding this comment.
The readonly property is being set to true unconditionally in the constructor. If this is intended to be configurable, consider setting it based on the parameters input.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.