refactor: use svgo to format snapshot svg #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Dec 25, 2024
Aarebecca
commented
- 使用 SVGO 格式化截图 SVG（对属性进行排序）
- Use SVGO to format the screenshot SVG (sort the attributes)
Walkthrough此PR通过使用SVGO替换xml-formatter来格式化SVG文件，主要是对SVG属性进行排序。此更改旨在优化SVG文件的格式化和管理。 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| const removeId = (svg: string, reserved?: Set<string>) => { | ||
| if (!reserved) return svg.replace(/ *id="[^"]*" */g, ' '); | ||
| return svg.replace(/ *id="([^"]*)" */g, (match, id) => (reserved.has(id) ? match : ' ')); | ||
| const format = (svg: SVGElement) => { |
There was a problem hiding this comment.
The format function now uses svgo to optimize SVGs, which is a good improvement for handling SVG formatting. Ensure that the optimize function is correctly configured to meet all formatting requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.