Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target node position error when create edge #6368

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

uhobnil
Copy link
Contributor

@uhobnil uhobnil commented Sep 27, 2024

fix target node position error #6367

@Aarebecca
Copy link
Contributor

It looks like the screenshots need to be updated for the two test cases below:
image
You can follow the instructions: https://g6-next.antv.antgroup.com/en/manual/contribute#update-test-snapshots

@uhobnil
Copy link
Contributor Author

uhobnil commented Sep 27, 2024

It looks like the screenshots need to be updated for the two test cases below:
image
You can follow the instructions: https://g6-next.antv.antgroup.com/en/manual/contribute#update-test-snapshots

Hi @Aarebecca , the screenshot has been updated.

@Aarebecca Aarebecca merged commit bfa1c9e into antvis:v5 Sep 29, 2024
3 checks passed
@uhobnil uhobnil deleted the create-edge branch September 29, 2024 06:40
resetsix pushed a commit to resetsix/G6 that referenced this pull request Oct 1, 2024
* fix: target node position error when create edge

* fix: use getElementData api to get source node and update test case screenshots
Aarebecca added a commit that referenced this pull request Oct 9, 2024
* docs: update Q&A

* docs: update docs

* fix: target node position error when create edge (#6368)

* fix: target node position error when create edge

* fix: use getElementData api to get source node and update test case screenshots

* chore: update version (#6375)

Co-authored-by: antv <[email protected]>

---------

Co-authored-by: antv <[email protected]>
Co-authored-by: uhobnil <[email protected]>
Co-authored-by: Aaron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants