Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tessellation options were not extended to component/face methods #1850

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

RobPasMue
Copy link
Member

Description

Missing exposure of the tessellation options. Face and components were not able to control them.

Issue linked

Related to #1328

@RobPasMue RobPasMue requested a review from a team as a code owner March 19, 2025 08:34
@github-actions github-actions bot added the bug Something isn't working label Mar 19, 2025
@RobPasMue RobPasMue self-assigned this Mar 19, 2025
@RobPasMue RobPasMue linked an issue Mar 19, 2025 that may be closed by this pull request
@RobPasMue RobPasMue enabled auto-merge (squash) March 19, 2025 08:48
@RobPasMue RobPasMue disabled auto-merge March 19, 2025 08:50
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (d3fcc9d) to head (86678b9).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 16.66% 5 Missing ⚠️
src/ansys/geometry/core/modeler.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1850      +/-   ##
==========================================
- Coverage   90.18%   90.12%   -0.06%     
==========================================
  Files          92       92              
  Lines        8801     8810       +9     
==========================================
+ Hits         7937     7940       +3     
- Misses        864      870       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue enabled auto-merge (squash) March 19, 2025 09:34
@RobPasMue RobPasMue merged commit 371d89a into blitz Mar 19, 2025
24 of 25 checks passed
@RobPasMue RobPasMue deleted the fix/tess-options-usage branch March 19, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Parameters to Tesselate() method
3 participants