-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove paramiko dependency #3454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As paramiko is not used by molecule core we should not list it as a dependency.
briantist
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense to me, but I don't understand why that test is failing.
That test failure is random and #3455 will fix it. |
hswong3i
added a commit
to alvistack/ansible-community-molecule
that referenced
this pull request
May 11, 2023
git clean -xdf tar zcvf ../python-molecule_3.6.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_3.6.1-1.spec mv ../python*-molecule*3.6.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-3.6.1/ rm -rf ../python*-molecule*3.6.1*.* See ansible#3454 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule
that referenced
this pull request
Jan 20, 2024
git clean -xdf tar zcvf ../python-molecule_3.6.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_3.6.1-1.spec cp ../python*-molecule*3.6.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-3.6.1/ rm -rf ../python*-molecule*3.6.1*.* See ansible#3454 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule
that referenced
this pull request
Feb 9, 2024
git clean -xdf tar zcvf ../python-molecule_3.6.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_3.6.1-1.spec cp ../python*-molecule*3.6.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-3.6.1/ rm -rf ../python*-molecule*3.6.1*.* See ansible#3454 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule
that referenced
this pull request
Feb 28, 2024
git clean -xdf tar zcvf ../python-molecule_3.6.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_3.6.1-1.spec cp ../python*-molecule*3.6.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-3.6.1/ rm -rf ../python*-molecule*3.6.1*.* See ansible#3454 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule
that referenced
this pull request
Jan 4, 2025
git clean -xdf tar zcvf ../python-molecule_3.6.1.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule.spec ../python-molecule_3.6.1-1.spec cp ../python*-molecule*3.6.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-3.6.1/ rm -rf ../python*-molecule*3.6.1*.* See ansible#3454 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As paramiko is not used by molecule core we should not
list it as a dependency.