Remove selinux from being exposed as a dependency #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove selinux from being exposed as a dependency of molecule becauase molecule itself does not need it. It would be up to the user to ensure that its ansible setup is correct. We still mention few hints about selinux and virtualenvs on our installation docs. This change will enabled us to avoid some blocking problems with newer pip-compile where the output cannot be kept the same on linux and non-linux.
ganeshrn
approved these changes
Jan 11, 2022
tadeboro
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove selinux from being exposed as a dependency of molecule because molecule itself does not need it. It would be up to the user to ensure that its ansible setup is correct. We still mention few hints about selinux and virtualenvs on our installation docs.
This change will enabled us to avoid some blocking problems with
newer pip-compile where the output cannot be kept the same on linux and non-linux.
Related to AAP and upcoming ee support, as ansible runtime may be on a different host thus installing selinux would be of no use. If someone needs selinux bindings they should install them explicitly.